You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/13 10:06:50 UTC

[GitHub] [arrow-rs] jhorstmann commented on pull request #1305: Enable clippy::float_equality_without_abs lint

jhorstmann commented on pull request #1305:
URL: https://github.com/apache/arrow-rs/pull/1305#issuecomment-1037982411


   This float comparison with epsilon hint is a pet peeve of mine. The epsilon should not be needed if we expect a result that can be exactly represented in a float. I think the corresponding `float_cmp` lint was actually downgraded from "correctness" to "pedantic" recently, so I would prefer to rewrite those asserts without epsilon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org