You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/11 03:20:57 UTC

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4190: fix: fix graphql cannot cancel

warren830 commented on code in PR #4190:
URL: https://github.com/apache/incubator-devlake/pull/4190#discussion_r1066538909


##########
plugins/helper/graphql_async_client.go:
##########
@@ -194,7 +198,7 @@ func (apiClient *GraphqlAsyncClient) NextTick(task func() errors.Error, taskErro
 			return
 		default:
 			go func() {
-				// if set waitGroup done here, a serial of goruntine will block until son goruntine finish.
+				// if set waitGroup done here, a serial of goroutine will block until son goruntine finish.

Review Comment:
   Here is a typo “son”. Maybe you can use sub-goroutine 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org