You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2023/04/25 16:42:12 UTC
[PR] Spotless 2.x (logging-log4j2)
ppkarwasz opened a new pull request, #1446:
URL: https://github.com/apache/logging-log4j2/pull/1446
This PR formats all files using the configuration from `logging-parent`. This was contributors do not have to format lines they did not modify.
Suggestion on how to review this:
1. The first commit can be reviewed manually: https://github.com/apache/logging-log4j2/commit/7f4ef6b6cf696242105f7ad630aab7c6a20e9ffb
2. Checkout the first commit: `git checkout 7f4ef6b`,
3. Run spotless: `./mvnw spotless:apply`,
4. Compare your working tree with the second commit: `git diff 71fb98f`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spotless on branch `2x` (closes #1317) (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1446:
URL: https://github.com/apache/logging-log4j2/pull/1446#issuecomment-1522114664
This closes #1317 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spotless on branch `2x` (closes #1317) (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1446:
URL: https://github.com/apache/logging-log4j2/pull/1446#issuecomment-1533470681
I assume a lazy approval on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spotless on branch `2x` (closes #1317) (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #1446:
URL: https://github.com/apache/logging-log4j2/pull/1446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org