You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/09/07 18:04:40 UTC
[GitHub] [incubator-mxnet] iblis17 commented on a change in pull request
#15568: julia: rename build env var `MXNET_HOME` to `MXNET_ROOT`
iblis17 commented on a change in pull request #15568: julia: rename build env var `MXNET_HOME` to `MXNET_ROOT`
URL: https://github.com/apache/incubator-mxnet/pull/15568#discussion_r321978305
##########
File path: julia/deps/build.jl
##########
@@ -26,14 +26,35 @@ libmxnet_detected = false
libmxnet_curr_ver = get(ENV, "MXNET_COMMIT", "master")
curr_win = "20190608" # v1.5.0
+# TODO: remove MXNET_HOME backward compatibility in v1.7
if haskey(ENV, "MXNET_HOME")
- MXNET_HOME = ENV["MXNET_HOME"]
- @info("MXNET_HOME environment detected: $MXNET_HOME")
+ @warn "The environment variable `MXNET_HOME` has been renamed, please use `MXNET_ROOT` instead."
+end
+
+# TODO: remove MXNET_HOME backward compatibility in v1.7
Review comment:
ah, sure (https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-529131708)
```suggestion
# TODO: remove MXNET_HOME backward compatibility in v2.0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services