You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/05 02:28:02 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1038: [CELEBORN-91] Refactor memory tracker to support read buffer.
AngersZhuuuu commented on code in PR #1038:
URL: https://github.com/apache/incubator-celeborn/pull/1038#discussion_r1039090858
##########
common/src/main/java/org/apache/celeborn/common/network/server/memory/MemoryManager.java:
##########
@@ -38,69 +39,85 @@
import org.apache.celeborn.common.util.ThreadUtils;
import org.apache.celeborn.common.util.Utils;
-public class MemoryTracker {
- private static final Logger logger = LoggerFactory.getLogger(MemoryTracker.class);
- private static volatile MemoryTracker _INSTANCE = null;
+public class MemoryManager {
+ private static final Logger logger = LoggerFactory.getLogger(MemoryManager.class);
+ private static volatile MemoryManager _INSTANCE = null;
private long maxDirectorMemory = 0;
private final long pausePushDataThreshold;
private final long pauseReplicateThreshold;
private final long resumeThreshold;
private final long maxSortMemory;
- private final List<MemoryTrackerListener> memoryTrackerListeners = new ArrayList<>();
+ private final List<MemoryPressureListener> memoryPressureListeners = new ArrayList<>();
private final ScheduledExecutorService checkService =
- ThreadUtils.newDaemonSingleThreadScheduledExecutor("memory-tracker-check");
+ ThreadUtils.newDaemonSingleThreadScheduledExecutor("memory-manager-check");
Review Comment:
`memory-manager-checker`?
##########
common/src/main/java/org/apache/celeborn/common/network/server/memory/MemoryManager.java:
##########
@@ -38,69 +39,85 @@
import org.apache.celeborn.common.util.ThreadUtils;
import org.apache.celeborn.common.util.Utils;
-public class MemoryTracker {
- private static final Logger logger = LoggerFactory.getLogger(MemoryTracker.class);
- private static volatile MemoryTracker _INSTANCE = null;
+public class MemoryManager {
+ private static final Logger logger = LoggerFactory.getLogger(MemoryManager.class);
+ private static volatile MemoryManager _INSTANCE = null;
private long maxDirectorMemory = 0;
private final long pausePushDataThreshold;
private final long pauseReplicateThreshold;
private final long resumeThreshold;
private final long maxSortMemory;
- private final List<MemoryTrackerListener> memoryTrackerListeners = new ArrayList<>();
+ private final List<MemoryPressureListener> memoryPressureListeners = new ArrayList<>();
private final ScheduledExecutorService checkService =
- ThreadUtils.newDaemonSingleThreadScheduledExecutor("memory-tracker-check");
+ ThreadUtils.newDaemonSingleThreadScheduledExecutor("memory-manager-check");
private final ScheduledExecutorService reportService =
- ThreadUtils.newDaemonSingleThreadScheduledExecutor("memory-tracker-report");
+ ThreadUtils.newDaemonSingleThreadScheduledExecutor("memory-manager-reporter");
private final ExecutorService actionService =
- ThreadUtils.newDaemonSingleThreadExecutor("memory-tracker-action");
+ ThreadUtils.newDaemonSingleThreadExecutor("memory-manager-action");
Review Comment:
`memory-manager-actor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org