You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/07/03 07:40:03 UTC
[GitHub] [spark] panbingkun opened a new pull request, #41826: skip on jdk21
panbingkun opened a new pull request, #41826:
URL: https://github.com/apache/spark/pull/41826
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #41826: Skip some pyspark test on jdk21
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251598349
##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
],
)
Review Comment:
cc @HyukjinKwon @dongjoon-hyun FYI
I think we should determine how to ignore pyspark unittest that do not yet support Java 21, as they are also related to arrow-memory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41826: Skip some pyspark test on jdk21
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251868525
##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
],
)
Review Comment:
Yeah, we could just don't run PySpark tests for now in the daily build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41826: [SPARK-44298][BUILD] Disable PySpark test on the daily test of Java 21 before the new arrow version release
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251892341
##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
],
)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41826: Skip some pyspark test on jdk21
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251364990
##########
.github/workflows/build_and_test.yml:
##########
@@ -25,7 +25,7 @@ on:
java:
required: false
type: string
- default: 8
+ default: 21-ea
Review Comment:
Only for test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #41826: [SPARK-44298][BUILD] Disable PySpark test on the daily test of Java 21 before the new arrow version release
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #41826:
URL: https://github.com/apache/spark/pull/41826#issuecomment-1620911548
Merged to master. Thanks @panbingkun and @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #41826: Skip some pyspark test on jdk21
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251598349
##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
],
)
Review Comment:
cc @HyukjinKwon @dongjoon-hyun FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41826: Skip some pyspark test on jdk21
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251369362
##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
],
)
Review Comment:
I will only use `pyspark_sql` as a test here. If this idea is reasonable, I will proceed with the other modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41826: Skip some pyspark test on jdk21
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251824903
##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
],
)
Review Comment:
It makes sense to skip when there are few but I think we shouldn't just skip them like this if there are too many.
##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
],
)
Review Comment:
We should fix instead of just skipping them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #41826: Skip some pyspark test on jdk21
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #41826:
URL: https://github.com/apache/spark/pull/41826#issuecomment-1619311552
1.Before
https://github.com/apache/spark/actions/runs/5440417950/jobs/9893341039
<img width="1274" alt="image" src="https://github.com/apache/spark/assets/15246973/7fd36e33-2ad6-4e0d-a134-a9b18239093d">
2.After
https://github.com/panbingkun/spark/actions/runs/5444102515/jobs/9914235099
<img width="1062" alt="image" src="https://github.com/apache/spark/assets/15246973/93c36b87-f3d1-4929-84e1-5bf937c1adca">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #41826: Skip some pyspark test on jdk21
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251869680
##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
],
)
Review Comment:
fine to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #41826: Skip some pyspark test on jdk21
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251859201
##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
],
)
Review Comment:
Or for the daily test of Java 21, disable PySpark test first? The failed tests also need wait for the new arrow version be upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #41826: Skip some pyspark test on jdk21
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #41826:
URL: https://github.com/apache/spark/pull/41826#discussion_r1251877886
##########
dev/sparktestsupport/modules.py:
##########
@@ -436,75 +436,85 @@ def __hash__(self):
],
)
Review Comment:
Ok，let me to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang closed pull request #41826: [SPARK-44298][BUILD] Disable PySpark test on the daily test of Java 21 before the new arrow version release
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #41826: [SPARK-44298][BUILD] Disable PySpark test on the daily test of Java 21 before the new arrow version release
URL: https://github.com/apache/spark/pull/41826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org