You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "chunhui shen (Created) (JIRA)" <ji...@apache.org> on 2012/02/17 06:52:00 UTC
[jira] [Created] (HBASE-5423) Regionserver may block on
waitOnAllRegionsToClose when aborting
Regionserver may block on waitOnAllRegionsToClose when aborting
---------------------------------------------------------------
Key: HBASE-5423
URL: https://issues.apache.org/jira/browse/HBASE-5423
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: chunhui shen
Assignee: chunhui shen
If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "chunhui shen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211175#comment-13211175 ]
chunhui shen commented on HBASE-5423:
-------------------------------------
@Stack
It's better change the name on commit.
Thanks.
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: hbase-5423.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210466#comment-13210466 ]
stack commented on HBASE-5423:
------------------------------
Patch looks good Chunhui.
Change name of Set from addedRegionsToCallClose to closed.
Why do we have this Set? Are we calling close multiple times on same region?
So, we'd break even though online regions is not yet empty?
{code}
+ if (this.regionsInTransitionInRS.isEmpty()) {
+ break;
+ }
{code}
Thanks.
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: hbase-5423.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "stack (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-5423.
--------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
Hadoop Flags: Reviewed
Committed to TRUNK. Thanks for the patch Chunhui.
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.94.0
>
> Attachments: hbase-5423.patch, hbase-5423v2.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211060#comment-13211060 ]
stack commented on HBASE-5423:
------------------------------
@Chunhui Sounds good. Want me to change the name on commit or do you want to put up a new patch? I'd add a log that we were exiting though online regions too.... Good stuff.
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: hbase-5423.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214348#comment-13214348 ]
Hudson commented on HBASE-5423:
-------------------------------
Integrated in HBase-TRUNK #2667 (See [https://builds.apache.org/job/HBase-TRUNK/2667/])
HBASE-5423 Regionserver may block forever on waitOnAllRegionsToClose when aborting (Revision 1292647)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.94.0
>
> Attachments: hbase-5423.patch, hbase-5423v2.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210835#comment-13210835 ]
ramkrishna.s.vasudevan commented on HBASE-5423:
-----------------------------------------------
@Chunhui
Patch makes sense. Using a set is also fine with me.
+1 on patch except if there is any name change for the name suggested by Stack.
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: hbase-5423.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "chunhui shen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chunhui shen updated HBASE-5423:
--------------------------------
Summary: Regionserver may block forever on waitOnAllRegionsToClose when aborting (was: Regionserver may block on waitOnAllRegionsToClose when aborting)
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: hbase-5423.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215413#comment-13215413 ]
Hudson commented on HBASE-5423:
-------------------------------
Integrated in HBase-TRUNK-security #121 (See [https://builds.apache.org/job/HBase-TRUNK-security/121/])
HBASE-5423 Regionserver may block forever on waitOnAllRegionsToClose when aborting (Revision 1292647)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.94.0
>
> Attachments: hbase-5423.patch, hbase-5423v2.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "chunhui shen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210760#comment-13210760 ]
chunhui shen commented on HBASE-5423:
-------------------------------------
If we failed closing one region, we will remove it from RIT , so it maybe calling close multiple times on same region.
{code}
CloseRegionHandler#process(){
try{
...
region.close(abort)
...
}finally{
this.rsServices.getRegionsInTransitionInRS().
remove(this.regionInfo.getEncodedNameAsBytes());
}
}
{code}
Therefore, if we can't close some regions because of some exception, we should break even though online regions is not yet empty, otherwise, it may block forever on waitOnAllRegionsToClose
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: hbase-5423.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "chunhui shen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chunhui shen updated HBASE-5423:
--------------------------------
Attachment: hbase-5423v2.patch
Change the set name and add a log if online regions are not empty.
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: hbase-5423.patch, hbase-5423v2.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5423) Regionserver may block on
waitOnAllRegionsToClose when aborting
Posted by "chunhui shen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chunhui shen updated HBASE-5423:
--------------------------------
Attachment: hbase-5423.patch
We needn't wait failedClose regions to close.
> Regionserver may block on waitOnAllRegionsToClose when aborting
> ---------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: hbase-5423.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5423) Regionserver may block forever on
waitOnAllRegionsToClose when aborting
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214865#comment-13214865 ]
Zhihong Yu commented on HBASE-5423:
-----------------------------------
{code}
+ if (this.regionsInTransitionInRS.isEmpty()) {
+ if (!isOnlineRegionsEmpty()) {
+ LOG.info("We were exiting though online regions are not empty, because some regions failed closing");
{code}
I think regionsInTransitionOnRS is better name for the new Map.
The log line above exceeds 80 chars.
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.94.0
>
> Attachments: hbase-5423.patch, hbase-5423v2.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira