You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Patrick Hunt (Reopened) (JIRA)" <ji...@apache.org> on 2011/11/11 21:50:51 UTC

[jira] [Reopened] (ZOOKEEPER-1251) call checkSession at begin of PrepRequestProcessor.pRequest

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt reopened ZOOKEEPER-1251:
-------------------------------------


Turns out there is a bug in this (found while testing ZOOKEEPER-1208). It does not correctly handle checkSession failures - hdr is not set correctly and results in NPE in FinalRequestProcessor.
                
> call checkSession at begin of PrepRequestProcessor.pRequest
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-1251
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1251
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>         Attachments: ZOOKEEPER-1251.patch
>
>
> There are 6 locations that call checkSession. This can be reduced to one location and makes it also much clearer in which cases checkSession is called or not called.
> Note that in case that now the SessionMoved|Expired error is checked first before the check for a Marshalling error. However it shouldn't matter which error gets reported.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira