You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/11 17:07:00 UTC

[jira] [Commented] (SAMZA-1934) LocalApplicationRunner fails for LegacyTaskApplication app.class

    [ https://issues.apache.org/jira/browse/SAMZA-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646770#comment-16646770 ] 

ASF GitHub Bot commented on SAMZA-1934:
---------------------------------------

GitHub user sborya opened a pull request:

    https://github.com/apache/samza/pull/705

    SAMZA-1934: creating a LegacyTaskApplication fails.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sborya/samza LegacyTaskApp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #705
    
----
commit a31a7aa29b7be4bb46f8e651b6b8fa46a65b48e2
Author: Boris Shkolnik <bs...@...>
Date:   2017-10-16T22:25:49Z

    reduce debugging from info to debug in KafkaCheckpointManager.java

commit 410ce78ba1ff8dafa2587481473e62ac9cfa6f4f
Author: Boris S <bo...@...>
Date:   2017-10-17T01:20:04Z

    Merge branch 'master' of https://github.com/apache/samza

commit d4620d6690f74cad9472d0e27a1b31aeb4156c54
Author: Boris S <bo...@...>
Date:   2017-10-25T00:11:48Z

    Merge branch 'master' of https://github.com/apache/samza

commit bbffb79b8b9799a41e8e82ded60f83550736886b
Author: Boris S <bo...@...>
Date:   2017-10-25T00:54:20Z

    Merge branch 'master' of https://github.com/apache/samza

commit 010fa168ee2a290b93f5a3b0908709b2c19044ec
Author: Boris S <bo...@...>
Date:   2017-10-25T01:33:03Z

    Merge branch 'master' of https://github.com/apache/samza

commit 5e6f5fb5f9a9ee12ce35ee8eb1836a058521df20
Author: Boris Shkolnik <bs...@...>
Date:   2017-10-25T16:50:37Z

    Merge branch 'master' of https://github.com/apache/samza

commit 06b1ac36e9c67a3bd558a0fa592639b16fcbfda9
Author: Boris Shkolnik <bs...@...>
Date:   2017-10-25T16:50:55Z

    Merge branch 'master' of https://github.com/sborya/samza

commit 1ad58d43fbe00a57054cb85b0be2eef6ee6470a6
Author: Boris S <bo...@...>
Date:   2017-10-31T19:46:53Z

    Merge branch 'master' of https://github.com/apache/samza

commit dd39d089437905abb93aa1074474b28a18292a54
Author: Boris S <bo...@...>
Date:   2017-11-22T19:46:37Z

    Merge branch 'master' of https://github.com/apache/samza

commit 67e611ee47f0747b81c0de5d061f9888145b605a
Author: Boris S <bo...@...>
Date:   2018-01-10T17:50:40Z

    Merge branch 'master' of https://github.com/apache/samza

commit 0edf343b8c5360437fa10cc5a543696a4edcc319
Author: Boris S <bo...@...>
Date:   2018-06-08T17:15:36Z

    Merge branch 'master' of https://github.com/apache/samza

commit 88f855954e4d98aa3bdd3a3a778eb699a13ff659
Author: Boris S <bo...@...>
Date:   2018-08-02T20:29:58Z

    Merge branch 'master' of https://github.com/apache/samza

commit 78ad578cc022af3f9c5f9a15826a9dc010502a89
Author: Boris S <bo...@...>
Date:   2018-08-08T02:04:17Z

    Merge branch 'master' of https://github.com/apache/samza

commit 7887d884e8a062563a7e4b8b418d817828f51f23
Author: Boris S <bo...@...>
Date:   2018-08-13T06:48:39Z

    Merge branch 'master' of https://github.com/apache/samza

commit afb34d916b435c1c08fe80009cc7d47d8287e27f
Author: Boris S <bo...@...>
Date:   2018-08-13T06:48:54Z

    Merge branch 'master' of https://github.com/sborya/samza

commit 57fca52cc48a37622aa6b8b1f71a37733c378524
Author: Boris S <bo...@...>
Date:   2018-08-15T19:13:37Z

    Merge branch 'master' of https://github.com/apache/samza

commit 7f7b5594c21e9e3ebf25d243cbf078dbf6201a0f
Author: Boris S <bo...@...>
Date:   2018-08-22T18:31:26Z

    Merge branch 'master' of https://github.com/apache/samza

commit 8ab04b209eec4d035f126259305ae84318737d2e
Author: Boris S <bo...@...>
Date:   2018-08-30T18:43:21Z

    Merge branch 'master' of https://github.com/apache/samza

commit add733b85f78046badd9af36ebf533d19388151c
Author: Boris S <bo...@...>
Date:   2018-09-05T00:23:06Z

    Merge branch 'master' of https://github.com/apache/samza

commit 728dc18143618b80df6e74a373c0024ced34544b
Author: Boris S <bo...@...>
Date:   2018-09-07T22:17:47Z

    Merge branch 'master' of https://github.com/apache/samza

commit 952dbbe20a23fc318589b62a044ac7e2cc944fc0
Author: Boris S <bo...@...>
Date:   2018-09-11T02:06:24Z

    Merge branch 'master' of https://github.com/apache/samza

commit 927adff0b1d65baec79d8b1ca8b8e4cce63be032
Author: Boris S <bo...@...>
Date:   2018-09-20T16:38:51Z

    Merge branch 'master' of https://github.com/apache/samza

commit ceebdc3be011d2e5e503c9fcbd9a9038feadafd2
Author: Boris S <bo...@...>
Date:   2018-09-25T00:07:30Z

    Merge branch 'master' of https://github.com/apache/samza

commit 4f0a7460d09c8819e2e3bf4fa590942a4e70615d
Author: Boris S <bo...@...>
Date:   2018-09-26T01:09:00Z

    Merge branch 'master' of https://github.com/apache/samza

commit cdd811d3ba874f5b370f4d3352917b2ed2f4cd23
Author: Boris S <bs...@...>
Date:   2018-09-26T17:16:01Z

    Merge branch 'master' of https://github.com/apache/samza

commit f6966a8bf8802d8d547b62c53ea280f292694c34
Author: Boris S <bs...@...>
Date:   2018-09-27T21:26:25Z

    Merge branch 'master' of https://github.com/apache/samza

commit 450ea2eaf411672fe72f681f9c3348c94363a577
Author: Boris S <bs...@...>
Date:   2018-10-01T15:53:45Z

    Merge branch 'master' of https://github.com/apache/samza

commit 5f5d7a3e0531c9bf901685046a0f8fcf94596667
Author: Boris S <bs...@...>
Date:   2018-10-02T19:18:57Z

    Merge branch 'master' of https://github.com/apache/samza

commit 058217eaf9974309684c910781bb67c16500538a
Author: Boris S <bs...@...>
Date:   2018-10-04T17:51:51Z

    Merge branch 'master' of https://github.com/apache/samza

commit 78210724f132bbf71f75111fe298b9a55dbb8d52
Author: Boris S <bs...@...>
Date:   2018-10-08T23:51:09Z

    Merge branch 'master' of https://github.com/apache/samza

----


> LocalApplicationRunner fails for LegacyTaskApplication app.class
> ----------------------------------------------------------------
>
>                 Key: SAMZA-1934
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1934
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>            Priority: Major
>
> For legacy job we set app.class to LegacyTaskApplication.
> It is being run by LocalApplicationRunner and it calls ApplicationUtils to instantiate the application. When it gets LegacyTaskApplication as the app.class, it tries to run newInstance on it, and as the result throws an exception (because there is no default constructor).
> I think we should check app.class, and if it is LegacyTaskApplication - treat it the same way as a blank app.class - create an object of LegacyTaskApplication type.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)