[GitHub] [pinot] gortiz commented on a diff in pull request #8893: Optimize like to regexp conversion to do not include unnecessary ^.* and .*$

[GitBox <gi...@apache.org>]

gortiz commented on code in PR #8893:
URL: https://github.com/apache/pinot/pull/8893#discussion_r898762732


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##########
@@ -33,7 +33,16 @@ private RegexpPatternConverterUtils() {
    * Converts a LIKE pattern into REGEXP_LIKE pattern.
    */
   public static String likeToRegexpLike(String likePattern) {
-    return "^" + escapeMetaCharacters(likePattern).replace('_', '.').replace("%", ".*") + "$";
+    String converted = "^" + escapeMetaCharacters(likePattern).replace('_', '.').replace("%", ".*") + "$";

Review Comment:
   I'm not sure about that. This code is not in the hotpath. It just called once when `FilterContext` is created and that's all. Therefore the amount of memory generated should be negligible.
   
   Anyway, the change is easy to apply, so I'm going to do so.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org