You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Jonathan Keane (Jira)" <ji...@apache.org> on 2021/05/28 12:21:00 UTC

[jira] [Updated] (ARROW-12901) [R] Follow on to more examples

     [ https://issues.apache.org/jira/browse/ARROW-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Keane updated ARROW-12901:
-----------------------------------
    Description: 
I accidentally merged ARROW-12841 (PR: https://github.com/apache/arrow/pull/10368) I will review (post-facto) and we can use this for the PR changes if we need any.

Comments

https://github.com/apache/arrow/pull/10368/files#diff-9fe1a055f9a4df7088de4e0c759c20138422b8bdb9bba04ed74c7881aa787019R66-R67
Should this use {{@examplesIf}} ?

https://github.com/apache/arrow/pull/10368/files#diff-0229d62b9653ff7124e6e2f202e51d46d4d8fcaf14baf83ccf8c047c7c344579R78-R80
These are both genuine questions, I'm not sure we want to include either or both of them:
* This might be too much indirection, but would it be better/easier to use `write_dataset() here?
* Do we want to talk about reading a partitioned dataset here?

  was:I accidentally merged ARROW-12841 (PR: https://github.com/apache/arrow/pull/10368) I will review (post-facto) and we can use this for the PR changes if we need any.


> [R] Follow on to more examples
> ------------------------------
>
>                 Key: ARROW-12901
>                 URL: https://issues.apache.org/jira/browse/ARROW-12901
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Jonathan Keane
>            Assignee: Jonathan Keane
>            Priority: Major
>
> I accidentally merged ARROW-12841 (PR: https://github.com/apache/arrow/pull/10368) I will review (post-facto) and we can use this for the PR changes if we need any.
> Comments
> https://github.com/apache/arrow/pull/10368/files#diff-9fe1a055f9a4df7088de4e0c759c20138422b8bdb9bba04ed74c7881aa787019R66-R67
> Should this use {{@examplesIf}} ?
> https://github.com/apache/arrow/pull/10368/files#diff-0229d62b9653ff7124e6e2f202e51d46d4d8fcaf14baf83ccf8c047c7c344579R78-R80
> These are both genuine questions, I'm not sure we want to include either or both of them:
> * This might be too much indirection, but would it be better/easier to use `write_dataset() here?
> * Do we want to talk about reading a partitioned dataset here?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)