You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/19 09:25:39 UTC
[GitHub] [flink] Tartarus0zm opened a new pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Tartarus0zm opened a new pull request #12932:
URL: https://github.com/apache/flink/pull/12932
## What is the purpose of the change
FutureUtils#orTimeout maybe throw a TimeoutException without timeout message,
This is rather vague and not friendly enough to analyze the problem.
so i think maybe throw a TimeoutException with a timeout message is better.
## Brief change log
add timeout message for FutureUtils#orTimeout
## Verifying this change
no
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660617460
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615",
"triggerID" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"triggerType" : "PUSH"
}, {
"hash" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4620",
"triggerID" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f53c211684c08a543b06c56ac5b40f5d02247a80 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4620)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660617460
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615",
"triggerID" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"triggerType" : "PUSH"
}, {
"hash" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdf442e9d294808a06c85f9e705e81d42dc5eef3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615)
* f53c211684c08a543b06c56ac5b40f5d02247a80 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660617460
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615",
"triggerID" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdf442e9d294808a06c85f9e705e81d42dc5eef3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660617460
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdf442e9d294808a06c85f9e705e81d42dc5eef3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660763259
@zhijiangW @tillrohrmann please take a look, if you have time, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660617460
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615",
"triggerID" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"triggerType" : "PUSH"
}, {
"hash" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4620",
"triggerID" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e136026cbcd2ab8a0ebafa1d88bc1a81e0043",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5e6e136026cbcd2ab8a0ebafa1d88bc1a81e0043",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f53c211684c08a543b06c56ac5b40f5d02247a80 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4620)
* 5e6e136026cbcd2ab8a0ebafa1d88bc1a81e0043 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-661834180
@zentol thanks for your review! I has fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660616000
@StephanEwen @GJL @wuchong please take a look, if you have time, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12932:
URL: https://github.com/apache/flink/pull/12932#discussion_r458056398
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
##########
@@ -439,10 +453,30 @@ public RetryException(Throwable cause) {
long timeout,
TimeUnit timeUnit,
Executor timeoutFailExecutor) {
+ return orTimeout(future, timeout, timeUnit, timeoutFailExecutor, null);
+ }
+
+ /**
+ * Times the given future out after the timeout.
+ *
+ * @param future to time out
+ * @param timeout after which the given future is timed out
+ * @param timeUnit time unit of the timeout
+ * @param timeoutFailExecutor executor that will complete the future exceptionally after the timeout is reached
+ * @param timeoutMsg timeout message for exception
+ * @param <T> type of the given future
+ * @return The timeout enriched future
+ */
+ public static <T> CompletableFuture<T> orTimeout(
+ CompletableFuture<T> future,
+ long timeout,
+ TimeUnit timeUnit,
+ Executor timeoutFailExecutor,
+ String timeoutMsg) {
Review comment:
missing `@Nullable`
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
##########
@@ -1026,14 +1060,16 @@ public void onComplete(Throwable failure, U success) {
private static final class Timeout implements Runnable {
private final CompletableFuture<?> future;
+ private final String timeoutMsg;
- private Timeout(CompletableFuture<?> future) {
+ private Timeout(CompletableFuture<?> future, @Nullable String timeoutMsg) {
this.future = checkNotNull(future);
+ this.timeoutMsg = timeoutMsg;
}
@Override
public void run() {
- future.completeExceptionally(new TimeoutException());
+ future.completeExceptionally(null == timeoutMsg ? new TimeoutException() : new TimeoutException(timeoutMsg));
Review comment:
this distinction isn't necessary; `new TimeoutException(timeoutMsg)` will work in any case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #12932:
URL: https://github.com/apache/flink/pull/12932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660615774
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cdf442e9d294808a06c85f9e705e81d42dc5eef3 (Sun Jul 19 09:27:54 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18638).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660617460
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615",
"triggerID" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"triggerType" : "PUSH"
}, {
"hash" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4620",
"triggerID" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdf442e9d294808a06c85f9e705e81d42dc5eef3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615)
* f53c211684c08a543b06c56ac5b40f5d02247a80 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4620)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660617460
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615",
"triggerID" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"triggerType" : "PUSH"
}, {
"hash" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4620",
"triggerID" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e136026cbcd2ab8a0ebafa1d88bc1a81e0043",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4688",
"triggerID" : "5e6e136026cbcd2ab8a0ebafa1d88bc1a81e0043",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e6e136026cbcd2ab8a0ebafa1d88bc1a81e0043 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4688)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660617460
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615",
"triggerID" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cdf442e9d294808a06c85f9e705e81d42dc5eef3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12932: [FLINK-18638][runtime] FutureUtils support timeout message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12932:
URL: https://github.com/apache/flink/pull/12932#issuecomment-660617460
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4615",
"triggerID" : "cdf442e9d294808a06c85f9e705e81d42dc5eef3",
"triggerType" : "PUSH"
}, {
"hash" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4620",
"triggerID" : "f53c211684c08a543b06c56ac5b40f5d02247a80",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e136026cbcd2ab8a0ebafa1d88bc1a81e0043",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4688",
"triggerID" : "5e6e136026cbcd2ab8a0ebafa1d88bc1a81e0043",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f53c211684c08a543b06c56ac5b40f5d02247a80 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4620)
* 5e6e136026cbcd2ab8a0ebafa1d88bc1a81e0043 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4688)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org