You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/22 17:30:28 UTC

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8383: Deprecate the PostAggregationGapfill.

Jackie-Jiang commented on a change in pull request #8383:
URL: https://github.com/apache/pinot/pull/8383#discussion_r832426342



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/GapfillUtils.java
##########
@@ -189,15 +171,15 @@ public static GapfillType getGapfillType(QueryContext queryContext) {
     Preconditions.checkArgument(gapFillSelection != null && gapFillSelection.getFunction() != null,
         "Gapfill Expression should be function.");
     List<ExpressionContext> args = gapFillSelection.getFunction().getArguments();
-    Preconditions.checkArgument(args.size() > 5, "PreAggregateGapFill does not have correct number of arguments.");
+    Preconditions.checkArgument(args.size() > 5, "GapFill does not have correct number of arguments.");

Review comment:
       (minor) Treat `Gapfill` as one word, same for other exception messages
   ```suggestion
       Preconditions.checkArgument(args.size() > 5, "Gapfill does not have correct number of arguments.");
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org