You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/02 04:32:07 UTC

[GitHub] [incubator-superset] rusackas opened a new pull request #9445: [WiP] Migrating NVD3 viz controls, take 2

rusackas opened a new pull request #9445: [WiP] Migrating NVD3 viz controls, take 2
URL: https://github.com/apache/incubator-superset/pull/9445
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on issue #9445: [WiP] Migrating NVD3 viz controls, take 2

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9445: [WiP] Migrating NVD3 viz controls, take 2
URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607617786
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=h1) Report
   > Merging [#9445](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/621b4816b39a091dadd0b33af83246ac689b4fa6&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9445/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9445   +/-   ##
   =======================================
     Coverage   59.02%   59.02%           
   =======================================
     Files         379      379           
     Lines       12189    12189           
     Branches     3014     3014           
   =======================================
     Hits         7194     7194           
     Misses       4814     4814           
     Partials      181      181           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `38.80% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=footer). Last update [621b481...a664ff9](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on issue #9445: Migrating unique NVD3 viz controls

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9445: Migrating unique NVD3 viz controls
URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607617786
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=h1) Report
   > Merging [#9445](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c003189d0dd6af9766af273f17174a1d3ca02f88?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9445/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9445   +/-   ##
   =======================================
     Coverage   59.02%   59.02%           
   =======================================
     Files         381      380    -1     
     Lines       12189    12189           
     Branches     3014     3014           
   =======================================
     Hits         7194     7194           
   + Misses       4813     4812    -1     
   - Partials      182      183    +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `41.26% <ø> (+0.95%)` | :arrow_up: |
   | [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0% <0%> (ø)` | |
   | [...-frontend/src/explore/controlPanels/DeckScatter.js](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrU2NhdHRlci5qcw==) | `0% <0%> (ø)` | :arrow_up: |
   | [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrTXVsdGkuanM=) | | |
   | [...-frontend/src/explore/controlPanels/DeckGeojson.js](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrR2VvanNvbi5qcw==) | | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=footer). Last update [c003189...c5c05b7](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on issue #9445: [WiP] Migrating NVD3 viz controls, take 2

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9445: [WiP] Migrating NVD3 viz controls, take 2
URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607617786
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=h1) Report
   > Merging [#9445](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/621b4816b39a091dadd0b33af83246ac689b4fa6&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9445/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9445   +/-   ##
   =======================================
     Coverage   59.02%   59.02%           
   =======================================
     Files         379      380    +1     
     Lines       12189    12189           
     Branches     3014     3014           
   =======================================
     Hits         7194     7194           
   + Misses       4814     4812    -2     
   - Partials      181      183    +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `41.26% <ø> (+2.46%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=footer). Last update [621b481...c160631](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on issue #9445: Migrating unique NVD3 viz controls

Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9445: Migrating unique NVD3 viz controls
URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-608089062
 
 
   > @kristw something puzzling about this one...
   > 
   > As you can see I added/reverted a commit a couple of times. Long story short, [this commit](https://github.com/apache/incubator-superset/pull/9445/commits/5bc371f95bcea72d59438b4660992b824fc2029d) migrates the `stacked_style` control, but for some reason, that fails CI. Do you see any obvious reason? I'll make it a separate PR just to test/diagnose further.
   
   Actually, n/m, I opened another PR with this control (#9454) and found/fixed the test that was breaking. Once GitHub recovers from its outage, hopefully those commits show up and CI turns green.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on issue #9445: [WiP] Migrating NVD3 viz controls, take 2

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9445: [WiP] Migrating NVD3 viz controls, take 2
URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607617786
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=h1) Report
   > Merging [#9445](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/621b4816b39a091dadd0b33af83246ac689b4fa6&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9445/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9445   +/-   ##
   =======================================
     Coverage   59.02%   59.02%           
   =======================================
     Files         379      380    +1     
     Lines       12189    12189           
     Branches     3014     3014           
   =======================================
     Hits         7194     7194           
   + Misses       4814     4812    -2     
   - Partials      181      183    +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `41.26% <ø> (+2.46%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=footer). Last update [621b481...aae2d41](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas merged pull request #9445: Migrating unique NVD3 viz controls

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #9445: Migrating unique NVD3 viz controls
URL: https://github.com/apache/incubator-superset/pull/9445
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on issue #9445: [WiP] Migrating NVD3 viz controls, take 2

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9445: [WiP] Migrating NVD3 viz controls, take 2
URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607617786
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=h1) Report
   > Merging [#9445](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/621b4816b39a091dadd0b33af83246ac689b4fa6&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9445/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9445   +/-   ##
   =======================================
     Coverage   59.02%   59.02%           
   =======================================
     Files         379      380    +1     
     Lines       12189    12189           
     Branches     3014     3014           
   =======================================
     Hits         7194     7194           
   + Misses       4814     4812    -2     
   - Partials      181      183    +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `41.26% <ø> (+2.46%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=footer). Last update [621b481...dc1a696](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas edited a comment on issue #9445: Migrating unique NVD3 viz controls

Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on issue #9445: Migrating unique NVD3 viz controls
URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607967275
 
 
   @kristw something puzzling about this one...
   
   As you can see I added/reverted a commit a couple of times. Long story short, [this commit](https://github.com/apache/incubator-superset/pull/9445/commits/5bc371f95bcea72d59438b4660992b824fc2029d) migrates the `stacked_style` control, but for some reason, that fails CI. Do you see any obvious reason? I'll make it a separate PR just to test/diagnose further.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on issue #9445: Migrating unique NVD3 viz controls

Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9445: Migrating unique NVD3 viz controls
URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607967275
 
 
   @kristw something puzzling about this one...
   
   As you can see I added/reverted a commit a couple of times. Long story short, [this commit](https://github.com/apache/incubator-superset/pull/9445/commits/5bc371f95bcea72d59438b4660992b824fc2029d) migrates the `stacked_style` control, but for some reason, that fails CI. Do you see any obvious reason?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on issue #9445: [WiP] Migrating NVD3 viz controls, take 2

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9445: [WiP] Migrating NVD3 viz controls, take 2
URL: https://github.com/apache/incubator-superset/pull/9445#issuecomment-607617786
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=h1) Report
   > Merging [#9445](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/621b4816b39a091dadd0b33af83246ac689b4fa6&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9445/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9445   +/-   ##
   =======================================
     Coverage   59.02%   59.02%           
   =======================================
     Files         379      379           
     Lines       12189    12189           
     Branches     3014     3014           
   =======================================
     Hits         7194     7194           
     Misses       4814     4814           
     Partials      181      181           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `38.80% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=footer). Last update [621b481...3ad3253](https://codecov.io/gh/apache/incubator-superset/pull/9445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org