You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2013/12/11 03:13:53 UTC
Review Request 16171: HIVE-5679 add date support to metastore JDO/SQL
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16171/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA
Diffs
-----
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java a98d9d1
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java 93e9942
metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g 00e90cb
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 4b7fc73
ql/src/test/queries/clientpositive/partition_date.q 3c031db
ql/src/test/results/clientpositive/partition_date.q.out 3462a1b
Diff: https://reviews.apache.org/r/16171/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 16171: HIVE-5679 add date support to metastore JDO/SQL
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Jan. 9, 2014, 7:23 p.m., Ashutosh Chauhan wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, line 776
> > <https://reviews.apache.org/r/16171/diff/2/?file=396602#file396602line776>
> >
> > I wonder if we should support pushdown for different types. I guess for first cut, it might be sufficient to just support pushdown when value type and column type exactly match.
> > Problem in being lenient by such implicit conversions is there could be bugs which users might run into it. If exact match suffices, than we don't need to worry about this code path. If there is demand for implicit conversion it can always be added later on.
This is actually merely to handle parsing ambiguity - filter.g cannot know if '2014-01-10' (w/quotes) is a date or a string, we want it to work with either column. Given that it doesn't parse quoted strings now one case can be removed. But the other still makes sense
> On Jan. 9, 2014, 7:23 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/partition_date.q, line 3
> > <https://reviews.apache.org/r/16171/diff/2/?file=396607#file396607line3>
> >
> > Any specific reason to change type of region column?
I needed to introduce a bogus date value
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16171/#review31453
-----------------------------------------------------------
On Dec. 11, 2013, 7:41 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16171/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 7:41 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java a98d9d1
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
> metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java 93e9942
> metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g 00e90cb
> ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 4b7fc73
> ql/src/test/queries/clientpositive/partition_date.q 3c031db
> ql/src/test/results/clientpositive/partition_date.q.out 3462a1b
>
> Diff: https://reviews.apache.org/r/16171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 16171: HIVE-5679 add date support to metastore JDO/SQL
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16171/#review31453
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/16171/#comment59945>
I wonder if we should support pushdown for different types. I guess for first cut, it might be sufficient to just support pushdown when value type and column type exactly match.
Problem in being lenient by such implicit conversions is there could be bugs which users might run into it. If exact match suffices, than we don't need to worry about this code path. If there is demand for implicit conversion it can always be added later on.
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<https://reviews.apache.org/r/16171/#comment59946>
Seems like we can remove this debug code now.
metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g
<https://reviews.apache.org/r/16171/#comment59947>
Is this still true? I thought you figured out a way to do this in parser by doing look ahead.
ql/src/test/queries/clientpositive/partition_date.q
<https://reviews.apache.org/r/16171/#comment59948>
Any specific reason to change type of region column?
- Ashutosh Chauhan
On Dec. 11, 2013, 7:41 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16171/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 7:41 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java a98d9d1
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
> metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java 93e9942
> metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g 00e90cb
> ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 4b7fc73
> ql/src/test/queries/clientpositive/partition_date.q 3c031db
> ql/src/test/results/clientpositive/partition_date.q.out 3462a1b
>
> Diff: https://reviews.apache.org/r/16171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 16171: HIVE-5679 add date support to metastore JDO/SQL
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16171/
-----------------------------------------------------------
(Updated Jan. 10, 2014, 7:29 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java bc062f4
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java adf80d7
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java 5c9ed2b
metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g 00e90cb
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3dbbff4
ql/src/test/queries/clientpositive/partition_date.q 3c031db
ql/src/test/results/clientpositive/partition_date.q.out 3462a1b
Diff: https://reviews.apache.org/r/16171/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 16171: HIVE-5679 add date support to metastore JDO/SQL
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16171/
-----------------------------------------------------------
(Updated Dec. 11, 2013, 7:41 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java a98d9d1
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java 93e9942
metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g 00e90cb
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 4b7fc73
ql/src/test/queries/clientpositive/partition_date.q 3c031db
ql/src/test/results/clientpositive/partition_date.q.out 3462a1b
Diff: https://reviews.apache.org/r/16171/diff/
Testing
-------
Thanks,
Sergey Shelukhin