You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Joseph Percivall (JIRA)" <ji...@apache.org> on 2018/10/12 16:51:00 UTC
[jira] [Commented] (NIFI-5694) StandardSSLContextService references
configContext in a non-thread safe manner
[ https://issues.apache.org/jira/browse/NIFI-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648112#comment-16648112 ]
Joseph Percivall commented on NIFI-5694:
----------------------------------------
FYI, I originally had another comment in the description[1] but turns out this wasn't a root cause. I've not super well versed on why/how but I have a PKCS12 file which is also valid as a JKS file (verified using openssl + keytool). Something weird with the generation of the trust factory leads it to a state where it successfully created the trust factory when treating the file as JKS but not as PKCS12.
This ticket is still an issue though and should be addressed.
[1]
{noformat}
I believe this is the cause of the weirdness I'm seeing where I have the SSL context "successfully" configured with a truststore of type "JKS" and am able to use it with an InovokeHttp processor. The problem is that the truststore is actually P12 (verified on the command line). I believe the issue came about because I wasn't sure if the type/password was correct and was enabling+disabling+reconfiguring it in rapid succession. {noformat}
> StandardSSLContextService references configContext in a non-thread safe manner
> ------------------------------------------------------------------------------
>
> Key: NIFI-5694
> URL: https://issues.apache.org/jira/browse/NIFI-5694
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.7.1
> Reporter: Joseph Percivall
> Priority: Major
>
> configContext is a variable which is accessed from many different threads (validate, enable, and any processor which calls "createSSLContext"). It is not declared with any thread safe modifier[1]. Potentially leading to odd behavior.
>
> The other shared variables should be marked with a thread-safe modifier as well.
> [1] [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-ssl-context-bundle/nifi-ssl-context-service/src/main/java/org/apache/nifi/ssl/StandardSSLContextService.java#L121]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)