You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by xh...@apache.org on 2019/01/18 20:51:18 UTC

[incubator-pinot] branch master updated: [TE] - Fix true anomaly definition to include expected anomaly (#3709)

This is an automated email from the ASF dual-hosted git repository.

xhsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 4716f74  [TE] - Fix true anomaly definition to include expected anomaly  (#3709)
4716f74 is described below

commit 4716f74a4256b5d9832c49219753a9ca711c0fca
Author: Xiaohui Sun <xh...@linkedin.com>
AuthorDate: Fri Jan 18 12:51:13 2019 -0800

    [TE] - Fix true anomaly definition to include expected anomaly  (#3709)
    
    * [TE] - Fix true anomaly definition to include expected anomaly for performance page
    
    * [TE] - Put ture positive logic into a helper function
    
    * Revert "[TE] - Put ture positive logic into a helper function"
    
    This reverts commit 8440a3358192008196982ad294b71fb301800979.
    
    * [TE] - use isAnomaly for anomaly check
---
 .../thirdeye/detector/email/filter/PrecisionRecallEvaluator.java      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detector/email/filter/PrecisionRecallEvaluator.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detector/email/filter/PrecisionRecallEvaluator.java
index 5aaf35c..b0dbefd 100644
--- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detector/email/filter/PrecisionRecallEvaluator.java
+++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detector/email/filter/PrecisionRecallEvaluator.java
@@ -203,8 +203,8 @@ public class PrecisionRecallEvaluator {
       if (feedback != null && feedback.getFeedbackType() != null && feedback.getFeedbackType()
           .equals(AnomalyFeedbackType.ANOMALY_NEW_TREND)) {
         isLabeledTrueAnomalyNewTrend = true;
-      } else if (feedback != null && feedback.getFeedbackType() != null && feedback.getFeedbackType()
-          .equals(AnomalyFeedbackType.ANOMALY)) {
+      } else if (feedback != null && feedback.getFeedbackType() != null &&
+          (feedback.getFeedbackType().isAnomaly())) {
         isLabeledTrueAnomaly = true;
       }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org