You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by phfsantos <gi...@git.apache.org> on 2015/07/01 00:44:49 UTC
[GitHub] cordova-plugin-file pull request: Windows prefix paths
GitHub user phfsantos opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/121
Windows prefix paths
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phfsantos/cordova-plugin-file Windows-Prefix-Paths
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 9964a72846fc72e10e91ebb786f62710dfd85624
Author: Pedro Santos <or...@hotmail.com>
Date: 2015-02-12T22:14:11Z
Adding Path prefixes for windows
commit 54ed471425930ec8a3cd84192df21c82270e8cfd
Author: Pedro Santos <or...@hotmail.com>
Date: 2015-06-17T15:29:08Z
Merge pull request #1 from apache/master
Merge With head
commit c0af477892f896399194e5572117aef70b8ac2a1
Author: Pedro Santos <or...@hotmail.com>
Date: 2015-06-17T15:29:47Z
Merge branch 'master' of https://github.com/phfsantos/cordova-plugin-file into Windows-Prefix-Paths
commit d145ff983125084294a2c98e66577a53b4caa190
Author: Pedro Santos <or...@hotmail.com>
Date: 2015-06-30T22:30:56Z
Few fixes for windows paths
commit 9a85425822fd242827699b3afb38a29371e9351e
Author: Pedro Santos <or...@hotmail.com>
Date: 2015-06-30T22:37:24Z
Merge pull request #2 from apache/master
Merge With head
commit 7082def41cf232011e99db0020f2edde49113a05
Author: Pedro Santos <or...@hotmail.com>
Date: 2015-06-30T22:37:37Z
Merge branch 'master' of https://github.com/phfsantos/cordova-plugin-file into Windows-Prefix-Paths
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Windows prefix paths
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/121#issuecomment-132746891
@ekambarrao
Please stop hijacking other people's pull requests.
Your post is about the plugin itself, and not this code. Try stack-overflow, the cordova slack channel, or the phonegap mailing list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Windows prefix paths
Posted by ekambarrao <gi...@git.apache.org>.
Github user ekambarrao commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/121#issuecomment-132689968
I was using this plugin in visual studio 2015 cordova app, and ran the app in windows phone 8.1, Does this app work on windows phone 8.1, It is showing some localsystem and also creating files and folders. but they are not visible if browse thru phone file browser and similarly whatever phones has, they are not visible to my code. what is wrong? Does this really work with windows phone 8.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Windows prefix paths
Posted by ghenry22 <gi...@git.apache.org>.
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/121#issuecomment-150114300
Have tried this on a windows 10 universal app and had some issues.
cordova.file values seem to return a absolute path eg:
cordova.file.dataDirectory returns c:\... etc when I would expect it to return ms-appdata:///local/ which is the accessible path for the app to reach persistent storage.
with the absolute path returned functions like checkDir, checkFile always fail.
window.resolvelocalfilesystemurl(cordova.file.dataDirectory) always throws a error code 5 encoding error when using this PR.
If I remove this PR code and go back to master and manually specify the value of cordova.file.dataDirectory to the ms-appdata url above then resolvelocalfilesystemurl works as expected as do other core file plugin functions like checkdir, checkfile etc.
so I have reverted back to using the current release of the file plugin with the following code added to my app.js:
//Init file systems for Windows
if (cordova.platformId === "windows"){
console.log("platform is windows");
cordova.file = {
dataDirectory: "ms-appdata:///local/",
cacheDirectory: "ms-appdata:///temp/",
tempDirectory: "ms-appdata:///temp/",
applicationDirectory: "ms-appdata:///"
};
};
This resolve the immediate problem and the app works now when I build for the windows platform and test on windows 10, but perhaps you could adjust this PR to take this into account so that the cordova.file.* constants work as expected for the file systems that are available on windows without requiring a workaround.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Windows prefix paths
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org