[GitHub] [arrow] pitrou commented on a change in pull request #8711: ARROW-10652: [C++][Gandiva] Make gandiva cache size configurable

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #8711:
URL: https://github.com/apache/arrow/pull/8711#discussion_r528759595



##########
File path: cpp/src/gandiva/cache.h
##########
@@ -26,7 +28,12 @@ namespace gandiva {
 template <class KeyType, typename ValueType>
 class Cache {
  public:
-  explicit Cache(size_t capacity = CACHE_SIZE) : cache_(capacity) {}
+  explicit Cache(size_t capacity) : cache_(capacity) {
+    std::cout << "Creating gandiva cache with capacity: " << capacity << std::endl;

Review comment:
       Two things:
   1) I don't think it's ok to unconditionally log such informational messages. Please use e.g. `ARROW_LOG(INFO)`.
   2) Please avoid, if at all possible, exposing such IO in header files. Better define the `Cache` constructor in `cache.cc`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org