You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Daniel Toffetti (JIRA)" <ji...@apache.org> on 2008/02/04 14:13:08 UTC
[jira] Created: (WICKET-1318) NavigatorLabel should be localizable
NavigatorLabel should be localizable
------------------------------------
Key: WICKET-1318
URL: https://issues.apache.org/jira/browse/WICKET-1318
Project: Wicket
Issue Type: Improvement
Components: wicket, wicket-extensions
Affects Versions: 1.3.0-final, 1.3.1, 1.3.2
Environment: All
Reporter: Daniel Toffetti
Priority: Trivial
Fix For: 1.3.1, 1.3.2, 1.3.0-final
In org\apache\wicket\extensions\markup\html\repeater\data\table\NavigatorLabel.java:
private NavigatorLabel(final String id, final PageableComponent table)
{
super(id);
setModel(new StringResourceModel("NavigatorLabel", this, new Model(new LabelModelObject(
table)), "Showing ${from} to ${to} of ${of}"));
}
The message "Showing x to y of z" is hardcoded, it should be extracted to a .properties file in order to allow for localization of the message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1318) NavigatorLabel should be localizable
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1318:
---------------------------------------
Fix Version/s: (was: 1.3.2)
(was: 1.3.0-final)
(was: 1.3.1)
> NavigatorLabel should be localizable
> ------------------------------------
>
> Key: WICKET-1318
> URL: https://issues.apache.org/jira/browse/WICKET-1318
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-final, 1.3.1, 1.3.2
> Environment: All
> Reporter: Daniel Toffetti
> Assignee: Igor Vaynberg
> Priority: Trivial
>
> In org\apache\wicket\extensions\markup\html\repeater\data\table\NavigatorLabel.java:
> private NavigatorLabel(final String id, final PageableComponent table)
> {
> super(id);
> setModel(new StringResourceModel("NavigatorLabel", this, new Model(new LabelModelObject(
> table)), "Showing ${from} to ${to} of ${of}"));
> }
> The message "Showing x to y of z" is hardcoded, it should be extracted to a .properties file in order to allow for localization of the message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1318) NavigatorLabel should be localizable
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1318.
-----------------------------------
Resolution: Invalid
Assignee: Igor Vaynberg
actually the hardcoded message is the fallback in case no .properties key was found. the first paremeter NavigatorLabel is the resource key that will be checked.
> NavigatorLabel should be localizable
> ------------------------------------
>
> Key: WICKET-1318
> URL: https://issues.apache.org/jira/browse/WICKET-1318
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-final, 1.3.1, 1.3.2
> Environment: All
> Reporter: Daniel Toffetti
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.3.1, 1.3.2, 1.3.0-final
>
>
> In org\apache\wicket\extensions\markup\html\repeater\data\table\NavigatorLabel.java:
> private NavigatorLabel(final String id, final PageableComponent table)
> {
> super(id);
> setModel(new StringResourceModel("NavigatorLabel", this, new Model(new LabelModelObject(
> table)), "Showing ${from} to ${to} of ${of}"));
> }
> The message "Showing x to y of z" is hardcoded, it should be extracted to a .properties file in order to allow for localization of the message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.