You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Brett Porter <br...@apache.org> on 2006/04/26 05:20:58 UTC
Re: svn commit: r397067 - /maven/plugins/trunk/maven-javadoc-plugin/src/test/java/org/apache/maven/plugin/javadoc/JavadocJarTest.java
Three's a logic error here - it won't actually validate if a field is
missing, or if an unknown field is found.
I suggest constructing a set of entries, then doing the asserts based on
set.contains( name );
Cheers,
Brett
oching@apache.org wrote:
> Author: oching
> Date: Tue Apr 25 20:13:09 2006
> New Revision: 397067
>
> URL: http://svn.apache.org/viewcvs?rev=397067&view=rev
> Log:
> Changed the assertions in the testDefaultConfiguration() method. One of the assertions failed because of the order of the zip file entries.
>
> Modified:
> maven/plugins/trunk/maven-javadoc-plugin/src/test/java/org/apache/maven/plugin/javadoc/JavadocJarTest.java
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r397067 - /maven/plugins/trunk/maven-javadoc-plugin/src/test/java/org/apache/maven/plugin/javadoc/JavadocJarTest.java
Posted by Odea Ching <oc...@exist.com>.
Okay, I'll try to fix this today.
Thanks,
Deng
Brett Porter wrote:
> Three's a logic error here - it won't actually validate if a field is
> missing, or if an unknown field is found.
>
> I suggest constructing a set of entries, then doing the asserts based
> on set.contains( name );
>
> Cheers,
> Brett
>
> oching@apache.org wrote:
>
>> Author: oching
>> Date: Tue Apr 25 20:13:09 2006
>> New Revision: 397067
>>
>> URL: http://svn.apache.org/viewcvs?rev=397067&view=rev
>> Log:
>> Changed the assertions in the testDefaultConfiguration() method. One
>> of the assertions failed because of the order of the zip file entries.
>>
>> Modified:
>>
>> maven/plugins/trunk/maven-javadoc-plugin/src/test/java/org/apache/maven/plugin/javadoc/JavadocJarTest.java
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org