[Impala-ASF-CR] IMPALA-11823: Add more items to Impala web UI queries page

["Anonymous Coward (Code Review)" <ge...@cloudera.org>]

Hello Quanlong Huang, Kurt Deschler, Yifan Zhang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19417

to look at the new patch set (#11).

Change subject: IMPALA-11823: Add more items to Impala web UI queries page
......................................................................

IMPALA-11823: Add more items to Impala web UI queries page

When operating and maintaining an Impala cluster or analyzing historical
query performance, it will be helpful if we show the memory consumed,
the amount of data read, and other information of the query from the
historical query page of the web UI. The current historical query page
does not display these information, so we should count this information
when the query is executed and display it on the web page.

This patch modifies the query list page (/queries) and query detail
pages (/query_plan, etc.).
On the list page, some metrics are added for each query record,
including queuing time, memory usage, memory estimation, bytes read, and
bytes sent. In addition, the Details column now shows the query ID and
the position is adjusted to make them at the top of the record for easy
clicking.
On the query detail page, a similar record table is added to display the
key information of the current query. In addition, a timeline display is
added to the summary page (which is exactly the same as the timeline in
the profile, just for quick viewing). For queries that are running, the
above information will be automatically refreshed (only for the plan and
summary tabs).
To make it clear what each metric means, tooltips are added to all list
headers.

This patch also fixes an issue regarding invalid access to record.
Specifically, the original ImpalaServer::GetQueryRecord function cannot
guarantee that the returned query_record is always valid. After
returning, this value is not protected by query_log_lock_ and may become
an invalid iterator due to deleted entries in query_log_index_. This
patch uses shared_ptr instead of the original unique_ptr to extend the
lifetime of query_record after GetQueryRecord returns.

Change-Id: I19c75461a6405025fa433ae84d2c94d013fcaacb
---
M be/src/runtime/coordinator.h
M be/src/scheduling/admission-control-client.h
M be/src/scheduling/admission-control-service.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/local-admission-control-client.cc
M be/src/scheduling/local-admission-control-client.h
M be/src/scheduling/remote-admission-control-client.cc
M be/src/scheduling/remote-admission-control-client.h
M be/src/scheduling/schedule-state.cc
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
M common/protobuf/admission_control_service.proto
M www/queries.tmpl
M www/query_detail_tabs.tmpl
M www/query_plan.tmpl
M www/query_summary.tmpl
23 files changed, 522 insertions(+), 100 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/19417/11
-- 
To view, visit http://gerrit.cloudera.org:8080/19417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19c75461a6405025fa433ae84d2c94d013fcaacb
Gerrit-Change-Number: 19417
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <18...@163.com>
Gerrit-Reviewer: Anonymous Coward <18...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>