You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by jayapalu <gi...@git.apache.org> on 2017/04/06 05:46:36 UTC

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

Github user jayapalu commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1908#discussion_r110082657
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ---
    @@ -625,15 +627,20 @@ protected ExecutionResult cleanupNetworkElementCommand(final IpAssocCommand cmd)
     
                     // there is only one ip in this public vlan and removing it, so
                     // remove the nic
    -                if (ipsCount == 1 && !ip.isAdd()) {
    -                    removeVif = true;
    +                if (lastIp != null && lastIp.equalsIgnoreCase("true") && !ip.isAdd()) {
    --- End diff --
    
    In CitrixresourceBase StringUtils is used from the  com.cloud.utils.StringUtils. So using  StringUtils from java.lang will be ambiguous.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---