[GitHub] [pulsar-client-go] BewareMyPower commented on a diff in pull request #903: [Issue 183] [Feat] Support cumulative acknowledge

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #903:
URL: https://github.com/apache/pulsar-client-go/pull/903#discussion_r1057098391


##########
pulsar/consumer.go:
##########
@@ -231,6 +231,14 @@ type Consumer interface {
 	// AckID the consumption of a single message, identified by its MessageID
 	AckID(MessageID) error
 
+	// CumulativeAck the reception of all the messages in the stream up to (and including)
+	// the provided message.
+	CumulativeAck(msg Message) error
+
+	// CumulativeAckID the reception of all the messages in the stream up to (and including)
+	// the provided message, identified by its MessageID
+	CumulativeAckID(msgID MessageID) error

Review Comment:
   Maybe it's better to use `AckIDCumulative` as the method name? Like the `acknowledge` and `acknowledgeCumulative` methods in other clients.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org