You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/23 11:31:27 UTC

[GitHub] [pulsar] lhotari opened a new pull request #10342: [Tests] Fix AvroSchemaTest on JDK11

lhotari opened a new pull request #10342:
URL: https://github.com/apache/pulsar/pull/10342


   Fixes #10122
   
   ### Motivation
   
   - see #10122 
   
   ### Modifications
   
   - When testing time fields at millisecond precision, use `LocalTime.now().truncatedTo(ChronoUnit.MILLIS)` instead of `LocalTime.now()` . 
    
   - On Java 8, `LocalTime.now()` has millisecond precision, but on Java 11, there is microsecond precision by default. The change in JDK is https://bugs.openjdk.java.net/browse/JDK-8068730 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10342: [Tests] Fix AvroSchemaTest on JDK11

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10342:
URL: https://github.com/apache/pulsar/pull/10342#issuecomment-825681273


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10342: [Tests] Fix AvroSchemaTest on JDK11

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10342:
URL: https://github.com/apache/pulsar/pull/10342


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari removed a comment on pull request #10342: [Tests] Fix AvroSchemaTest on JDK11

Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10342:
URL: https://github.com/apache/pulsar/pull/10342#issuecomment-825628694






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10342: [Tests] Fix AvroSchemaTest on JDK11

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10342:
URL: https://github.com/apache/pulsar/pull/10342#issuecomment-825628694


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org