You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/05/20 18:28:07 UTC

[GitHub] [netbeans] matthiasblaesing opened a new pull request, #4136: Fix maven groupId completion

matthiasblaesing opened a new pull request, #4136:
URL: https://github.com/apache/netbeans/pull/4136

   MavenIndexer dropped the caching of the allGroups and rootGroups
   properties in the index:
   
   https://github.com/apache/maven-indexer/commit/c231db602b5cea9ed20eba617de5a5a846ef5faa
   
   After the index is loaded there are two options:
   
   a) rebuild the groups list from the index
   b) cache the group list after indexing
   
   NetBeans expects the index to be readily be available and thus option
   a is not an option (rebuilding the group list runs over the full index
   and is in the minute range). As there are only a few entrypoints that
   modify the index caching the group list looks like a viable option.
   
   Closes: #4102
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing merged pull request #4136: Fix maven groupId completion

Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged PR #4136:
URL: https://github.com/apache/netbeans/pull/4136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #4136: Fix maven groupId completion

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4136:
URL: https://github.com/apache/netbeans/pull/4136#issuecomment-1133668515

   I mentioned it in the review comment, going to attach a diff next time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #4136: Fix maven groupId completion

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4136:
URL: https://github.com/apache/netbeans/pull/4136#issuecomment-1133195995

   Another issue found in maven-indexer was reported as [MINDEXER-157](https://issues.apache.org/jira/browse/MINDEXER-157) is worked around and a fix is proposed here: https://github.com/apache/maven-indexer/pull/211.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #4136: Fix maven groupId completion

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4136:
URL: https://github.com/apache/netbeans/pull/4136#issuecomment-1133659688

   I looked at your change and looks sane to me, adjusted a little and squashed. I intent to merge once this gets green. maven-indexer talks about going jdk 11+, this might or might not be a problem for NetBeans and I want to get back to being able to use master.
   
   I was surprised by the push into this PR - I'd have expected a heads-up before (yes I'll try to remember to uncheck the "allow edits" checkbox).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists