You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "realMartinez (via GitHub)" <gi...@apache.org> on 2023/08/10 12:50:26 UTC

[GitHub] [camel-k] realMartinez opened a new pull request, #4664: feat: added annotations support for route trait

realMartinez opened a new pull request, #4664:
URL: https://github.com/apache/camel-k/pull/4664

   <!-- Description -->
   
       - Added route annotations implementation
       - Added unit tests
       - Added documentation
   
   _CLI parameter usage example for clarity:_
   `-t "haproxy.router.openshift.io/balance'=true"`
   
   
   
   
   <!--
   -->
   
   **Release Note**
   ```release-note
   feat: added annotations support for route trait
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] claudio4j commented on pull request #4664: feat: added annotations support for route trait

Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #4664:
URL: https://github.com/apache/camel-k/pull/4664#issuecomment-1673398716

   The trait parameter should be prefixed with the trait name, so given the example in the description, should it be ?
   ```
   -t route.annotations "haproxy.router.openshift.io/balance'=true"
   ```
   
   There is `'` at the end of `balance'`, where is the initial sign ? I am asking because, given the attribute is a `map[string]string`, I can't remember how that is set from a CLI perspective.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] github-actions[bot] commented on pull request #4664: feat: added annotations support for route trait

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4664:
URL: https://github.com/apache/camel-k/pull/4664#issuecomment-1674296671

   :camel: **Thank you for contributing!**
   
   Code Coverage Report :heavy_check_mark: - Coverage unchanged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] realMartinez commented on pull request #4664: feat: added annotations support for route trait

Posted by "realMartinez (via GitHub)" <gi...@apache.org>.
realMartinez commented on PR #4664:
URL: https://github.com/apache/camel-k/pull/4664#issuecomment-1674289620

   > -t route.annotations "haproxy.router.openshift.io/balance'=true"
   > ```
   > 
   > There is `'` at the end of `balance'`, where is the initial sign ? I am asking because, given the attribute is a `map[string]string`, I can't remember how that is set from a CLI perspective.
   
   I must have made a mistake when writing documentation, it should be fixed now.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] github-actions[bot] commented on pull request #4664: feat: added annotations support for route trait

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4664:
URL: https://github.com/apache/camel-k/pull/4664#issuecomment-1673170566

   :camel: **Thank you for contributing!**
   
   Code Coverage Report :heavy_check_mark: - Coverage unchanged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] realMartinez commented on pull request #4664: feat: added annotations support for route trait

Posted by "realMartinez (via GitHub)" <gi...@apache.org>.
realMartinez commented on PR #4664:
URL: https://github.com/apache/camel-k/pull/4664#issuecomment-1674299967

   > Also, how to add a second annotation ? It would be good to add it as example in the description.
   
   You can repeat it multiple times for multiple annotations in a single line.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez merged pull request #4664: feat: added annotations support for route trait

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4664:
URL: https://github.com/apache/camel-k/pull/4664


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org