You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/07 03:03:53 UTC

[GitHub] [spark] Yikun opened a new pull request, #36476: [SPARK-39121][K8S][DOC] Fix format error on running-on-kubernetes doc

Yikun opened a new pull request, #36476:
URL: https://github.com/apache/spark/pull/36476

   ### What changes were proposed in this pull request?
   Fix format error on running-on-kubernetes doc
   
   ### Why are the changes needed?
   Fix format syntax error 
   
   
   ### Does this PR introduce _any_ user-facing change?
   No, unreleased doc only
   
   
   ### How was this patch tested?
   SKIP_API=1 bundle exec jekyll serve --watch
   
   ![image](https://user-images.githubusercontent.com/1736354/167235492-30fd24aa-f34b-44ea-96ce-480e918e2ec5.png)
   
   ![image](https://user-images.githubusercontent.com/1736354/167235498-719833d5-5f5b-4e0c-964f-ab9c7e8168b0.png)
   
   ![image](https://user-images.githubusercontent.com/1736354/167235506-adac9edd-1a34-4c04-886c-b7efcef3165c.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #36476: [SPARK-39121][K8S][DOCS] Fix format error on running-on-kubernetes doc

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #36476: [SPARK-39121][K8S][DOCS] Fix format error on running-on-kubernetes doc
URL: https://github.com/apache/spark/pull/36476


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Yikun commented on pull request #36476: [SPARK-39121][K8S][DOCS] Fix format error on running-on-kubernetes doc

Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #36476:
URL: https://github.com/apache/spark/pull/36476#issuecomment-1120154149

   @srowen @MaxGekk Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Yikun commented on a diff in pull request #36476: [SPARK-39121][K8S][DOC] Fix format error on running-on-kubernetes doc

Posted by GitBox <gi...@apache.org>.
Yikun commented on code in PR #36476:
URL: https://github.com/apache/spark/pull/36476#discussion_r867294317


##########
docs/running-on-kubernetes.md:
##########
@@ -1766,7 +1766,7 @@ To use Volcano as a custom scheduler the user needs to specify the following con
 --conf spark.kubernetes.scheduler.volcano.podGroupTemplateFile=/path/to/podgroup-template.yaml
 # Specify driver/executor VolcanoFeatureStep
 --conf spark.kubernetes.driver.pod.featureSteps=org.apache.spark.deploy.k8s.features.VolcanoFeatureStep
---conf spark.kubernetes.executor.pod.featureSteps=org.apache.spark.deploy.k8s.features.VolcanoFeatureStep```
+--conf spark.kubernetes.executor.pod.featureSteps=org.apache.spark.deploy.k8s.features.VolcanoFeatureStep

Review Comment:
   Before:
   ![image](https://user-images.githubusercontent.com/1736354/167235623-9f10712b-c68f-4179-a3da-29b73069ac15.png)
   
   After:
   ![image](https://user-images.githubusercontent.com/1736354/167235631-3d5c8252-0f41-455a-ac63-979977ad15ee.png)
   



##########
docs/running-on-kubernetes.md:
##########
@@ -1729,8 +1729,8 @@ Spark allows users to specify a custom Kubernetes schedulers.
 3. Specify scheduler feature step.
 
    Users may also consider to use <code>spark.kubernetes.{driver/executor}.pod.featureSteps</code> to support more complex requirements, including but not limited to:
-  - Create additional Kubernetes custom resources for driver/executor scheduling.
-  - Set scheduler hints according to configuration or existing Pod info dynamically.
+   - Create additional Kubernetes custom resources for driver/executor scheduling.
+   - Set scheduler hints according to configuration or existing Pod info dynamically.

Review Comment:
   Before:
   ![image](https://user-images.githubusercontent.com/1736354/167235581-7b3261ba-4a34-4c04-b98d-5c5594a45147.png)
   
   After:
   ![image](https://user-images.githubusercontent.com/1736354/167235595-cb67572c-b0b3-4fea-bd8a-d1745148999d.png)
   



##########
docs/running-on-kubernetes.md:
##########
@@ -1699,7 +1699,7 @@ Kubernetes supports [Pod priority](https://kubernetes.io/docs/concepts/schedulin
 
 Spark on Kubernetes allows defining the priority of jobs by [Pod template](#pod-template). The user can specify the <code>priorityClassName</code> in driver or executor Pod template <code>spec</code> section. Below is an example to show how to specify it:
 
-```
+```yaml

Review Comment:
   Before:
   ![image](https://user-images.githubusercontent.com/1736354/167235612-7d4ac29d-44b1-4841-81a4-5eab9d2c9999.png)
   
   After:
   ![image](https://user-images.githubusercontent.com/1736354/167235616-75e92cb2-ff78-4042-b847-75deaba98fd8.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Yikun commented on pull request #36476: [SPARK-39121][K8S][DOC] Fix format error on running-on-kubernetes doc

Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #36476:
URL: https://github.com/apache/spark/pull/36476#issuecomment-1120122944

   I'm so sorry I haven't find these error until I was doing [rc1 documentation](https://dist.apache.org/repos/dist/dev/spark/v3.3.0-rc1-docs/_site/running-on-kubernetes.html) check.
   
   Maybe we should also fix them in 3.3.0 too?
   
   cc @dongjoon-hyun @srowen @MaxGekk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #36476: [SPARK-39121][K8S][DOCS] Fix format error on running-on-kubernetes doc

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36476:
URL: https://github.com/apache/spark/pull/36476#issuecomment-1120153923

   +1, LGTM. Merging to master/3.3.
   Thank you, @Yikun, and @srowen for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org