You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2023/02/07 09:18:24 UTC
[GitHub] [doris] Gabriel39 opened a new pull request, #16474: [Bug](share hash table) Support shared hash table on Nereids
Gabriel39 opened a new pull request, #16474:
URL: https://github.com/apache/doris/pull/16474
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee merged pull request #16474: [Bug](share hash table) Support shared hash table on Nereids
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #16474:
URL: https://github.com/apache/doris/pull/16474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #16474: [Bug](share hash table) Support shared hash table on Nereids
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #16474:
URL: https://github.com/apache/doris/pull/16474#discussion_r1098449919
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1130,22 +1130,20 @@ private void computeFragmentExecParams() throws Exception {
// here choose the first instance to build hash table.
Map<TNetworkAddress, FInstanceExecParam> destHosts = new HashMap<>();
destParams.instanceExecParams.forEach(param -> {
- if (destHosts.containsKey(param.host)) {
- destHosts.get(param.host).instancesSharingHashTable.add(param.instanceId);
- return;
- }
- destHosts.put(param.host, param);
-
- param.buildHashTableForBroadcastJoin = true;
- TPlanFragmentDestination dest = new TPlanFragmentDestination();
- dest.fragment_instance_id = param.instanceId;
- try {
- dest.server = toRpcHost(param.host);
- dest.setBrpcServer(toBrpcHost(param.host));
- } catch (Exception e) {
- throw new RuntimeException(e);
+ if (!destHosts.containsKey(param.host)) {
Review Comment:
forget call ` destHosts.get(param.host).instancesSharingHashTable.add(param.instanceId);`
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1130,22 +1130,20 @@ private void computeFragmentExecParams() throws Exception {
// here choose the first instance to build hash table.
Map<TNetworkAddress, FInstanceExecParam> destHosts = new HashMap<>();
destParams.instanceExecParams.forEach(param -> {
- if (destHosts.containsKey(param.host)) {
- destHosts.get(param.host).instancesSharingHashTable.add(param.instanceId);
- return;
- }
- destHosts.put(param.host, param);
-
- param.buildHashTableForBroadcastJoin = true;
- TPlanFragmentDestination dest = new TPlanFragmentDestination();
- dest.fragment_instance_id = param.instanceId;
- try {
- dest.server = toRpcHost(param.host);
- dest.setBrpcServer(toBrpcHost(param.host));
- } catch (Exception e) {
- throw new RuntimeException(e);
+ if (!destHosts.containsKey(param.host)) {
Review Comment:
forget call ` destHosts.get(param.host).instancesSharingHashTable.add(param.instanceId);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org