You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "ulysses-you (via GitHub)" <gi...@apache.org> on 2024/03/08 09:06:59 UTC
[PR] [VL] Support lead window function [incubator-gluten]
ulysses-you opened a new pull request, #4902:
URL: https://github.com/apache/incubator-gluten/pull/4902
## What changes were proposed in this pull request?
This pr does:
- adds support lead window function
- do a small refactor for `ignoreNulls` option
- add `GlutenDataFrameWindowFunctionsSuite` for Spark33/34 which is missed before
## How was this patch tested?
add tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support lead window function [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4902:
URL: https://github.com/apache/incubator-gluten/pull/4902#issuecomment-1985317523
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/oap-project/gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/oap-project/gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support lead window function [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #4902:
URL: https://github.com/apache/incubator-gluten/pull/4902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support lead window function [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #4902:
URL: https://github.com/apache/incubator-gluten/pull/4902#issuecomment-1988616995
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_4902_time.csv</font></td>
<td><font color=#000000>log/native_master_03_10_2024_3ad58ce14_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>36.39</font></td>
<td><font color=#6F9915>35.86</font></td>
<td><font color=#6F9915>-0.536</font></td>
<td><font color=#6F9915>98.53%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>25.80</font></td>
<td><font color=#F92663>25.95</font></td>
<td><font color=#F92663>0.145</font></td>
<td><font color=#F92663>100.56%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>36.97</font></td>
<td><font color=#6F9915>36.82</font></td>
<td><font color=#6F9915>-0.151</font></td>
<td><font color=#6F9915>99.59%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>38.13</font></td>
<td><font color=#F92663>38.96</font></td>
<td><font color=#F92663>0.827</font></td>
<td><font color=#F92663>102.17%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>71.70</font></td>
<td><font color=#6F9915>70.83</font></td>
<td><font color=#6F9915>-0.872</font></td>
<td><font color=#6F9915>98.78%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>7.35</font></td>
<td><font color=#F92663>7.41</font></td>
<td><font color=#F92663>0.058</font></td>
<td><font color=#F92663>100.79%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>84.72</font></td>
<td><font color=#6F9915>83.10</font></td>
<td><font color=#6F9915>-1.630</font></td>
<td><font color=#6F9915>98.08%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>85.17</font></td>
<td><font color=#F92663>85.35</font></td>
<td><font color=#F92663>0.186</font></td>
<td><font color=#F92663>100.22%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>121.69</font></td>
<td><font color=#6F9915>118.73</font></td>
<td><font color=#6F9915>-2.954</font></td>
<td><font color=#6F9915>97.57%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>45.76</font></td>
<td><font color=#6F9915>42.98</font></td>
<td><font color=#6F9915>-2.779</font></td>
<td><font color=#6F9915>93.93%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>20.03</font></td>
<td><font color=#F92663>21.60</font></td>
<td><font color=#F92663>1.565</font></td>
<td><font color=#F92663>107.81%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q12</font></td>
<td><font color=#6F9915>28.78</font></td>
<td><font color=#6F9915>25.06</font></td>
<td><font color=#6F9915>-3.719</font></td>
<td><font color=#6F9915>87.08%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q13</font></td>
<td><font color=#6F9915>47.29</font></td>
<td><font color=#6F9915>46.55</font></td>
<td><font color=#6F9915>-0.745</font></td>
<td><font color=#6F9915>98.43%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>21.88</font></td>
<td><font color=#6F9915>19.73</font></td>
<td><font color=#6F9915>-2.149</font></td>
<td><font color=#6F9915>90.18%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>31.95</font></td>
<td><font color=#F92663>32.39</font></td>
<td><font color=#F92663>0.433</font></td>
<td><font color=#F92663>101.35%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q16</font></td>
<td><font color=#6F9915>14.28</font></td>
<td><font color=#6F9915>13.72</font></td>
<td><font color=#6F9915>-0.564</font></td>
<td><font color=#6F9915>96.05%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>102.13</font></td>
<td><font color=#6F9915>100.46</font></td>
<td><font color=#6F9915>-1.667</font></td>
<td><font color=#6F9915>98.37%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q18</font></td>
<td><font color=#6F9915>142.67</font></td>
<td><font color=#6F9915>142.43</font></td>
<td><font color=#6F9915>-0.237</font></td>
<td><font color=#6F9915>99.83%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q19</font></td>
<td><font color=#6F9915>13.86</font></td>
<td><font color=#6F9915>13.62</font></td>
<td><font color=#6F9915>-0.244</font></td>
<td><font color=#6F9915>98.24%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>28.45</font></td>
<td><font color=#6F9915>26.87</font></td>
<td><font color=#6F9915>-1.579</font></td>
<td><font color=#6F9915>94.45%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q21</font></td>
<td><font color=#6F9915>227.28</font></td>
<td><font color=#6F9915>225.05</font></td>
<td><font color=#6F9915>-2.235</font></td>
<td><font color=#6F9915>99.02%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>13.91</font></td>
<td><font color=#F92663>14.04</font></td>
<td><font color=#F92663>0.130</font></td>
<td><font color=#F92663>100.94%</font></td>
</tr>
<tr>
<td><font color=#6F9915>total</font></td>
<td><font color=#6F9915>1246.20</font></td>
<td><font color=#6F9915>1227.48</font></td>
<td><font color=#6F9915>-18.717</font></td>
<td><font color=#6F9915>98.50%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support lead window function [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4902:
URL: https://github.com/apache/incubator-gluten/pull/4902#issuecomment-1985317893
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support lead window function [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4902:
URL: https://github.com/apache/incubator-gluten/pull/4902#issuecomment-1987516300
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support lead window function [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4902:
URL: https://github.com/apache/incubator-gluten/pull/4902#issuecomment-1987595086
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support lead window function [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4902:
URL: https://github.com/apache/incubator-gluten/pull/4902#issuecomment-1987514408
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support lead window function [incubator-gluten]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #4902:
URL: https://github.com/apache/incubator-gluten/pull/4902#issuecomment-1987700949
cc @PHILO-HE @rui-mo thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org