You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@giraph.apache.org by er...@apache.org on 2012/10/04 01:50:10 UTC
svn commit: r1393836 - in /giraph/trunk: CHANGELOG
src/main/java/org/apache/giraph/graph/BspServiceMaster.java
Author: ereisman
Date: Wed Oct 3 23:50:10 2012
New Revision: 1393836
URL: http://svn.apache.org/viewvc?rev=1393836&view=rev
Log:
GIRAPH-351: Fail job early when there is no input (aching via ereisman)
Modified:
giraph/trunk/CHANGELOG
giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java
Modified: giraph/trunk/CHANGELOG
URL: http://svn.apache.org/viewvc/giraph/trunk/CHANGELOG?rev=1393836&r1=1393835&r2=1393836&view=diff
==============================================================================
--- giraph/trunk/CHANGELOG (original)
+++ giraph/trunk/CHANGELOG Wed Oct 3 23:50:10 2012
@@ -1,6 +1,7 @@
Giraph Change Log
Release 0.2.0 - unreleased
+ GIRAPH-351: Fail job early when there is no input (aching via ereisman)
GIRAPH-212: Security is busted since GIRAPH-168. (ekoontz via
aching)
Modified: giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java
URL: http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java?rev=1393836&r1=1393835&r2=1393836&view=diff
==============================================================================
--- giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java (original)
+++ giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java Wed Oct 3 23:50:10 2012
@@ -527,6 +527,15 @@ public class BspServiceMaster<I extends
// INPUT_SPLIT_SAMPLE_PERCENT is set to something other than 100
List<InputSplit> splitList =
generateInputSplits(healthyWorkerInfoList.size());
+ if (splitList.isEmpty()) {
+ LOG.fatal("createInputSplits: Failing job due to 0 input splits, " +
+ "check input of " +
+ getConfiguration().getVertexInputFormatClass().getName() + "!");
+ getContext().setStatus("Failing job due to 0 input splits, " +
+ "check input of " +
+ getConfiguration().getVertexInputFormatClass().getName() + "!");
+ failJob();
+ }
if (healthyWorkerInfoList.size() > splitList.size()) {
LOG.warn("createInputSplits: Number of inputSplits=" +
splitList.size() + " < " +