You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henri Yandell (JIRA)" <ji...@apache.org> on 2008/03/19 07:56:24 UTC
[jira] Updated: (COLLECTIONS-280) Add Predicate that failed
PredicatedCollection.validate to IllegalArgumentException text
[ https://issues.apache.org/jira/browse/COLLECTIONS-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell updated COLLECTIONS-280:
--------------------------------------
Fix Version/s: 3.3
> Add Predicate that failed PredicatedCollection.validate to IllegalArgumentException text
> ----------------------------------------------------------------------------------------
>
> Key: COLLECTIONS-280
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-280
> Project: Commons Collections
> Issue Type: Improvement
> Components: Collection
> Affects Versions: 3.2
> Environment: N/A
> Reporter: Chris Lewis
> Priority: Minor
> Fix For: 3.3
>
>
> In a project I'm working on at the moment, I decorate some of my sets with multiple Predicates. In the event that validation fails, it would be nice to know which predicate caused the failure.
> I'd suggest changing the validate method in PredicatedCollection to:
> protected void validate(Object object) {
> if (predicate.evaluate(object) == false) {
> throw new IllegalArgumentException("Cannot add Object '" + object + "' - Predicate '" + predicate + "' rejected it");
> }
> }
> Then, the user can provide a toString method with relevant information about the Predicate and why it might cause the validation to fail if they choose.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.