[GitHub] [calcite] vvysotskyi commented on a change in pull request #1551: [CALCITE-3457] RexSimplify incorrectly simplifies IS NOT NULL operator with ITEM call

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #1551: [CALCITE-3457] RexSimplify incorrectly simplifies IS NOT NULL operator with ITEM call
URL: https://github.com/apache/calcite/pull/1551#discussion_r341803945
 
 

 ##########
 File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
 ##########
 @@ -1990,7 +2018,8 @@ LogicalProject(EXPR$0=[+($1, $5)], EXPR$1=[SUM($6) OVER (PARTITION BY $4 RANGE B
     </TestCase>
     <TestCase name="testPushProjectPastSetOp">
         <Resource name="sql">
-            <![CDATA[select sal from (select * from emp e1 union all select * from emp e2)]]>
+            <![CDATA[select sal from
+(select * from emp e1 union all select * from emp e2)]]>
         </Resource>
 
 Review comment:
   I have updated this file as it was recommended in this comment: https://issues.apache.org/jira/browse/CALCITE-3393?focusedCommentId=16958082&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16958082. But if you insist, I can leave only changes required for my tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services