You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/09/15 16:29:05 UTC

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24851


Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................

KUDU-3804: Fix symbol hiding for protobuf well-known types

The exported client library's linker version script (symbols.map) hides
glog, gflags, and protobuf symbols behind a "*google::*" C++ demangled
wildcard so they don't collide with a host application's own copies of
these libraries.

protobuf's generated descriptor tables for its well-known types
(any.proto, descriptor.proto, source_context.proto, type.proto,
wrappers.proto) are emitted as plain, non-namespaced globals (e.g.
descriptor_table_google_2fprotobuf_2fdescriptor_2eproto and
TableStruct_google_2fprotobuf_2fdescriptor_2eproto::offsets), so they
are not matched by "*google::*" and leak out of the DSO with default
visibility.

This was harmless while the client's bundled protobuf matched the host
application's protobuf version, but after bumping protobuf to 3.21.9 for
GCC-15 support (KUDU-3803), the leaked symbols collide with an older,
ABI-incompatible protobuf runtime statically linked into the host
application, corrupting process-wide descriptor state and crashing the
host process on startup.

Add explicit patterns to symbols.map to localize these well-known-type
descriptor table symbols, both in their plain (unmangled) form and their
C++-mangled form.

Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Assisted-By: Claude Sonnet 5 (GitHub Copilot)
---
M src/kudu/client/symbols.map
1 file changed, 15 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/24851/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG@22
PS1, Line 22: 
            : Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
            : Assisted-By: Claude Sonnet
> While you are at this, did you have a chance to run ./bin/client_symbol-tes
I don't fully understand what's going on. Addressing a symptom here, and I've narrowed it to hiding descriptor_table specifically.

client_symbol-test.sh passes without this patch and with it. Without it shows

    Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fany_2eproto'
    Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fdescriptor_2eproto'
    Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fsource_5fcontext_2eproto'
    Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2ftype_2eproto'
    Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fwrappers_2eproto'
    Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fany_2eproto_getter()'
    Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2ftype_2eproto_getter()'
    Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fwrappers_2eproto_getter()'
    Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fdescriptor_2eproto_getter()'
    Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fsource_5fcontext_2eproto_getter()'
    ...
    Skipping non-strong and non-global symbol 'TableStruct_google_2fprotobuf_2fany_2eproto::offsets'
    Skipping non-strong and non-global symbol 'TableStruct_google_2fprotobuf_2ftype_2eproto::offsets'
    Skipping non-strong and non-global symbol 'TableStruct_google_2fprotobuf_2fwrappers_2eproto::offsets'
    Skipping non-strong and non-global symbol 'TableStruct_google_2fprotobuf_2fdescriptor_2eproto::offsets'
    Skipping non-strong and non-global symbol 'TableStruct_google_2fprotobuf_2fsource_5fcontext_2eproto::offsets'

With it, the descriptor_table symbols are removed, as expected.



-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 20:05:47 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2966/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 17:17:23 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG@22
PS1, Line 22: This was harmless while the client's bundled protobuf matched the host
            : application's protobuf version, but after bumping protobuf to 3.21.9 for
            : GCC-15 support (KUDU-3803)
> That's fair, some incorrect assumptions went into this. Impala has been usi
While you are at this, did you have a chance to run ./bin/client_symbol-test.sh from the Kudu client build directory?  Did it report any issues?

Ideally, the issue of exposing such symbols should have been caught by that test.



-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 18:05:07 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/24851 )

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................


Abandoned

https://gerrit.cloudera.org/#/c/24859/ is the right fix.
-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24851

to look at the new patch set (#2).

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................

KUDU-3804: Fix symbol hiding for protobuf well-known types

The exported client library's linker version script (symbols.map) hides
glog, gflags, and protobuf symbols behind a "*google::*" C++ demangled
wildcard so they don't collide with a host application's own copies of
these libraries.

protobuf's generated descriptor tables for its well-known types
(any.proto, descriptor.proto, source_context.proto, type.proto,
wrappers.proto) are emitted as plain, non-namespaced globals (e.g.
descriptor_table_google_2fprotobuf_2fdescriptor_2eproto) so they are not
matched by "*google::*" and leak out of the DSO with default visibility.

This causes conflicts in Impala which crash while loading
libkudu_client. Mask them out as well.

Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Assisted-By: Claude Sonnet 5 (GitHub Copilot)
---
M src/kudu/client/symbols.map
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/24851/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2967/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 20:21:38 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG@22
PS1, Line 22: This was harmless while the client's bundled protobuf matched the host
            : application's protobuf version, but after bumping protobuf to 3.21.9 for
            : GCC-15 support (KUDU-3803)
I'm not sure this makes sense to me.  The updates made in the context of KUDU-3803 didn't change anything for protobuf compilation in Kudu's thirdparty.  Also, Kudu has upgraded protobuf in 3rd-party more than 1.5 year ago (February 2025), so the mismatch between Kudu's protobuf and Impala's protobuf has been there for a while.

Is this an AI slop or I'm missing something?


http://gerrit.cloudera.org:8080/#/c/24851/1/src/kudu/client/symbols.map
File src/kudu/client/symbols.map:

http://gerrit.cloudera.org:8080/#/c/24851/1/src/kudu/client/symbols.map@37
PS1, Line 37:     descriptor_table_google_2fprotobuf_2f*;
So, where does this belong?  Why is this here and under C++ section as well?  This doesn't make sense to me.


http://gerrit.cloudera.org:8080/#/c/24851/1/src/kudu/client/symbols.map@48
PS1, Line 48:       *google::protobuf::MapKey*;
Isn't this covered already by pattern at line 41?



-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 17:44:21 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2966/


-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Sep 2026 16:29:14 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2967/


-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 19:32:49 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................


Patch Set 2:

This seems to be the result of an incompatibility linking Kudu with lld and Impala with gold. I'd like to have the option to continue linking Kudu with gold until we can update Impala's toolchain to build with lld.


-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 20:29:30 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3804: Fix symbol hiding for protobuf well-known types

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )

Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG@22
PS1, Line 22: This was harmless while the client's bundled protobuf matched the host
            : application's protobuf version, but after bumping protobuf to 3.21.9 for
            : GCC-15 support (KUDU-3803)
> I'm not sure this makes sense to me.  The updates made in the context of KU
That's fair, some incorrect assumptions went into this. Impala has been using 879a8f9e2, which appears to include protobuf 3.21.9. I'm not entirely sure why I started to run into issues after trying to build against latest master; I'd get errors like

    Sep 15 07:32:38 localhost kernel: [  785.208989] statestored[36994]: segfault at 260000 ip 00007f301044bbcd sp 00007ffe5842eaa0 error 4 in libkudu_client.so.0.1.0[7f300fe72000+688000] likely on CPU 4 (core 8, socket 0)

trying to start impala binaries. This patch against Kudu fixed it; I'm still working through trying to upgrade protobuf in Impala to see if that would work.


http://gerrit.cloudera.org:8080/#/c/24851/1/src/kudu/client/symbols.map
File src/kudu/client/symbols.map:

http://gerrit.cloudera.org:8080/#/c/24851/1/src/kudu/client/symbols.map@37
PS1, Line 37:     descriptor_table_google_2fprotobuf_2f*;
> So, where does this belong?  Why is this here and under C++ section as well
Good question. I can try to clean this up.


http://gerrit.cloudera.org:8080/#/c/24851/1/src/kudu/client/symbols.map@48
PS1, Line 48:       *google::protobuf::MapKey*;
> Isn't this covered already by pattern at line 41?
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/24851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d
Gerrit-Change-Number: 24851
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 17:52:27 +0000
Gerrit-HasComments: Yes