[PR] feat(mcp): negotiate stdio protocol eras [maka]

["me2seeks (via GitHub)" <gi...@apache.org>]

me2seeks opened a new pull request, #3807:
URL: https://github.com/apache/maka/pull/3807

   ## Summary
   
   Completes the final stdio slice of the MCP dual-era rollout.
   
   - Extend stdio config with `legacy | auto | 2026-07-28`, bump the wrapper to v3, and migrate v1/v2 without rewriting until the next mutation.
   - Preserve omitted stdio config as the one-child legacy path. Explicit auto or modern pins use the SDK v2 sibling probe, while Maka keeps ownership of the actual transport and closes the candidate on abort.
   - Add the protocol choice under the Desktop MCP editor's Advanced section, including copy that explains the extra probe process.
   - Move JSON import interpretation to the storage/main boundary and remove the renderer parser and broad replacement IPC, so config v3 has one schema authority.
   
   Fixes #1650
   
   ## Verification
   
   - `npm test` — all workspace tests passed
   - `npm --workspace @maka/mcp test` — 179 passed
   - `npm run lint`
   - `npm run format:check`
   - `npm run typecheck`
   - Desktop production build and CLI build
   - `npm run check:asf-headers`
   - `npx knip --workspace apps/desktop`
   - `npx knip --workspace packages/ui`
   - `git diff --check`
   
   The real stdio fixtures verify one-child omitted/legacy behavior, probe-before-actual ordering, identical launch inputs, stderr isolation, exact-pin failure without an actual child, and cancellation before and during discovery.
   
   The programmatic Electron window smoke was not completed: this Linux checkout's Electron `chrome-sandbox` is not installed as root with mode `4755`. The production renderer/main/preload build completed before native launch reached that host-level gate.
   
   ## Migration and review focus
   
   An absent stdio protocol remains legacy and starts no discovery sibling. The extra process is authorized only by an explicit `auto` or `2026-07-28` value.
   
   The official SDK remains the only negotiation authority. Maka does not add a custom probe state machine, PID registry, discovery cache, or second negotiated-protocol record; `McpClientManager` retains only the actual client/transport lifecycle and live status.
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex helped design and implement config v3, stdio negotiation wiring, Desktop authoring, real-process tests, documentation, and correctness/simplification reviews under human direction. Every affected commit includes a `Generated-by: Codex` trailer.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] feat(mcp): negotiate stdio protocol eras [maka]

["Astro-Han (via GitHub)" <gi...@apache.org>]

Astro-Han merged PR #3807:
URL: https://github.com/apache/maka/pull/3807


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org