You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by abalanonline <gi...@git.apache.org> on 2017/05/05 18:17:57 UTC
[GitHub] jmeter pull request #295: Fix to 61071
GitHub user abalanonline opened a pull request:
https://github.com/apache/jmeter/pull/295
Fix to 61071
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abalanonline/jmeter 61071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/295.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #295
----
commit b71640eb8c3bfbb88dee63f16ce8e76e2cdb9b47
Author: Aleksei Balan <ab...@gmail.com>
Date: 2017-05-05T18:09:06Z
Fix to 61071
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #295: Fix to 61071
Posted by abalanonline <gi...@git.apache.org>.
Github user abalanonline commented on the issue:
https://github.com/apache/jmeter/pull/295
Hello @pmouawad ,
Test case provided.
There are errors in build. Failed to resolve host name: jmeter.apache.org
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #295: Fix to 61071
Posted by abalanonline <gi...@git.apache.org>.
Github user abalanonline commented on the issue:
https://github.com/apache/jmeter/pull/295
Hello @pmouawad ,
I investigated the HdrHistogram project. Unfortunately we cannot use it in JMeter right now.
1. It do not have median method implemented.
2. It do not have the interpolated percentile method either.
3. It have the same bug calculating the 75th percentile of 11 data values {3, 6, 7, 8, 8, 9, 10, 13, 15, 16, 20} (example from Wikipedia)
So I suggest either fix the bugs in current org.apache.jorphan library. Or implement the necessary methods (and fix the bug) in HdrHistogram and after that use it in JMeter.
I provided two pull requests in case you prefer a quick solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #295: Fix to 61071
Posted by abalanonline <gi...@git.apache.org>.
Github user abalanonline commented on the issue:
https://github.com/apache/jmeter/pull/295
There are two methods for calculating percentile: Nearest Rank method and Linear Interpolation Between Closest Ranks method.
Median equal to percentile 50 if interpolation method is used. But for JMeter measuring purposes the nearest rank percentile should be used because perc 90 gives the exact maximum time for 90% of tests and this is what JMeter users are expecting.
This is why the median should be calculated separately (or we can implement interpolation method and use it for particular median purpose).
By the way getPercentPoint method is [failing also](https://gist.github.com/abalanonline/9b128faa67e2459b765c1ef56454684b). I will raise a bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #295: Fix to 61071
Posted by abalanonline <gi...@git.apache.org>.
GitHub user abalanonline reopened a pull request:
https://github.com/apache/jmeter/pull/295
Fix to 61071
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abalanonline/jmeter 61071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/295.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #295
----
commit b71640eb8c3bfbb88dee63f16ce8e76e2cdb9b47
Author: Aleksei Balan <ab...@gmail.com>
Date: 2017-05-05T18:09:06Z
Fix to 61071
commit 75a30f25367180578cdf08478829ffbbd55106cd
Author: Aleksei Balan <ab...@gmail.com>
Date: 2017-05-05T21:26:07Z
Median test case for bug 61071
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #295: Fix to 61071
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/295
Hello @abalanonline ,
Thanks for your PR.
Would it be possible to provide a current failing test case that shows the issue and confirms that your fix is ok ?
Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #295: Fix to 61071
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/295
Thanks for completing the PR.
Percentile 50 should be equal to median.
So I suspect the bug is in getPercentPoint().
I wonder if it's not occasion to switch to https://github.com/HdrHistogram/HdrHistogram
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #295: Fix to 61071
Posted by abalanonline <gi...@git.apache.org>.
Github user abalanonline commented on the issue:
https://github.com/apache/jmeter/pull/295
https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #295: Fix to 61071
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/295
Hi Team,
What shall we do ?
As per Felix note on dev mailing list, it is more an algorithm variation than a bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #295: Fix to 61071
Posted by abalanonline <gi...@git.apache.org>.
Github user abalanonline closed the pull request at:
https://github.com/apache/jmeter/pull/295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---