You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "labbomb (via GitHub)" <gi...@apache.org> on 2023/09/15 04:21:35 UTC
[GitHub] [incubator-paimon-webui] labbomb opened a new pull request, #41: Feat: Add Layout
labbomb opened a new pull request, #41:
URL: https://github.com/apache/incubator-paimon-webui/pull/41
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- What is the purpose of the change, or the associated issue -->
Please refer to the main `issue` [#40](https://github.com/apache/incubator-paimon-webui/issues/40).
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon-webui] SteNicholas merged pull request #41: [Feature] Introduce Layout
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas merged PR #41:
URL: https://github.com/apache/incubator-paimon-webui/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon-webui] SteNicholas commented on a diff in pull request #41: Feat: Add Layout
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #41:
URL: https://github.com/apache/incubator-paimon-webui/pull/41#discussion_r1326791508
##########
paimon-web-ui-new/src/api/request.ts:
##########
@@ -45,12 +45,12 @@ axle.axios.interceptors.request.use(
axle.axios.interceptors.response.use(
(response) => {
- const { code, message } = response.data
+ const { code, msg } = response.data
Review Comment:
Why change this file?
##########
paimon-web-ui-new/src/layouts/content/components/menubar/index.tsx:
##########
@@ -0,0 +1,67 @@
+/* Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License. */
+
+import i18n from '@/locales'
+import { useConfigStore } from '@/store/config'
+
+export default defineComponent({
+ name: 'MenuBar',
+ setup() {
+ const configStore = useConfigStore()
+
+ const menuOptions = ref([] as any[])
+
+ watch(
+ () => configStore.getCurrentLocale,
+ () => {
+ menuOptions.value = [
+ {
+ label: i18n.global.t('layout.playground'),
+ key: 'playground',
+ },
+ {
+ label: i18n.global.t('layout.metadata'),
+ key: 'metadata',
+ },
+ {
+ label: i18n.global.t('layout.CDC_Ingestion'),
Review Comment:
```suggestion
label: i18n.global.t('layout.cdc_ingestion'),
```
##########
paimon-web-ui-new/src/layouts/content/components/menubar/index.tsx:
##########
@@ -0,0 +1,67 @@
+/* Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License. */
+
+import i18n from '@/locales'
+import { useConfigStore } from '@/store/config'
+
+export default defineComponent({
+ name: 'MenuBar',
+ setup() {
+ const configStore = useConfigStore()
+
+ const menuOptions = ref([] as any[])
+
+ watch(
+ () => configStore.getCurrentLocale,
+ () => {
+ menuOptions.value = [
+ {
+ label: i18n.global.t('layout.playground'),
+ key: 'playground',
+ },
+ {
+ label: i18n.global.t('layout.metadata'),
+ key: 'metadata',
+ },
+ {
+ label: i18n.global.t('layout.CDC_Ingestion'),
+ key: 'CDC_Ingestion',
Review Comment:
```suggestion
key: 'cdc_ingestion',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon-webui] labbomb commented on a diff in pull request #41: [Feature] Introduce Layout
Posted by "labbomb (via GitHub)" <gi...@apache.org>.
labbomb commented on code in PR #41:
URL: https://github.com/apache/incubator-paimon-webui/pull/41#discussion_r1326795607
##########
paimon-web-ui-new/src/api/request.ts:
##########
@@ -45,12 +45,12 @@ axle.axios.interceptors.request.use(
axle.axios.interceptors.response.use(
(response) => {
- const { code, message } = response.data
+ const { code, msg } = response.data
Review Comment:
Because the field returned by the interface is msg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon-webui] SteNicholas commented on a diff in pull request #41: Feat: Add Layout
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #41:
URL: https://github.com/apache/incubator-paimon-webui/pull/41#discussion_r1326792655
##########
paimon-web-ui-new/src/locales/zh/modules/layout.ts:
##########
@@ -0,0 +1,25 @@
+/* Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License. */
+
+export default {
+ playground: '查询控制台',
+ metadata: '元数据管理',
+ CDC_Ingestion: 'CDC 集成',
+ system: '系统管理',
+ light: '浅色',
+ dark: '暗色'
+}
Review Comment:
New line here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org