You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/28 13:46:18 UTC

[GitHub] [beam] Amar3tto opened a new pull request, #24375: [CdapIO] Fix SparkReceiverIOIT

Amar3tto opened a new pull request, #24375:
URL: https://github.com/apache/beam/pull/24375

   Resolves #24257 
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] johnjcasey merged pull request #24375: [CdapIO] Fix SparkReceiverIOIT

Posted by GitBox <gi...@apache.org>.
johnjcasey merged PR #24375:
URL: https://github.com/apache/beam/pull/24375


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #24375: [CdapIO] Fix SparkReceiverIOIT

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24375:
URL: https://github.com/apache/beam/pull/24375#issuecomment-1331644783

   Looks like we need to bump the timeout. Test still failing: https://ci-beam.apache.org/view/PerformanceTests/job/beam_PerformanceTests_SparkReceiver_IO/95/console
   ```
   21:48:15     [Test ****] WARN org.apache.beam.runners.dataflow.DataflowPipelineJob - No terminal state was returned within allotted timeout. State value RUNNING
   21:50:35 
   21:50:35 org.apache.beam.sdk.io.sparkreceiver.SparkReceiverIOIT > testSparkReceiverIOReadsInStreamingWithOffset FAILED
   21:50:35     java.lang.AssertionError: expected:<5000000> but was:<3023859>
   21:50:35         at org.junit.Assert.fail(Assert.java:89)
   21:50:35         at org.junit.Assert.failNotEquals(Assert.java:835)
   21:50:35         at org.junit.Assert.assertEquals(Assert.java:647)
   21:50:35         at org.junit.Assert.assertEquals(Assert.java:633)
   21:50:35         at org.apache.beam.sdk.io.sparkreceiver.SparkReceiverIOIT.testSparkReceiverIOReadsInStreamingWithOffset(SparkReceiverIOIT.java:337)
   21:50:35 
   21:51:08 Gradle Test Executor 6 finished executing tests.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Amar3tto commented on pull request #24375: [CdapIO] Fix SparkReceiverIOIT

Posted by GitBox <gi...@apache.org>.
Amar3tto commented on PR #24375:
URL: https://github.com/apache/beam/pull/24375#issuecomment-1332096990

   
   
   
   > Looks like we need to bump the timeout. Test still failing: https://ci-beam.apache.org/view/PerformanceTests/job/beam_PerformanceTests_SparkReceiver_IO/95/console
   > 
   > ```
   > 21:48:15     [Test ****] WARN org.apache.beam.runners.dataflow.DataflowPipelineJob - No terminal state was returned within allotted timeout. State value RUNNING
   > 21:50:35 
   > 21:50:35 org.apache.beam.sdk.io.sparkreceiver.SparkReceiverIOIT > testSparkReceiverIOReadsInStreamingWithOffset FAILED
   > 21:50:35     java.lang.AssertionError: expected:<5000000> but was:<3023859>
   > 21:50:35         at org.junit.Assert.fail(Assert.java:89)
   > 21:50:35         at org.junit.Assert.failNotEquals(Assert.java:835)
   > 21:50:35         at org.junit.Assert.assertEquals(Assert.java:647)
   > 21:50:35         at org.junit.Assert.assertEquals(Assert.java:633)
   > 21:50:35         at org.apache.beam.sdk.io.sparkreceiver.SparkReceiverIOIT.testSparkReceiverIOReadsInStreamingWithOffset(SparkReceiverIOIT.java:337)
   > 21:50:35 
   > 21:51:08 Gradle Test Executor 6 finished executing tests.
   > ```
   
   Opened new PR: https://github.com/apache/beam/pull/24428


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #24375: [CdapIO] Fix SparkReceiverIOIT

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24375:
URL: https://github.com/apache/beam/pull/24375#issuecomment-1330526785

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @kennknowles for label java.
   R: @johnjcasey for label io.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org