[GitHub] [skywalking-java] zhyyu commented on a diff in pull request #369: Add MQ_TOPIC and MQ_BROKER tags for RocketMQ consumer's span

[GitBox <gi...@apache.org>]

zhyyu commented on code in PR #369:
URL: https://github.com/apache/skywalking-java/pull/369#discussion_r1008625163


##########
test/plugin/scenarios/rocketmq-scenario/config/expectedData.yaml:
##########
@@ -62,6 +62,8 @@ segmentItems:
             peer: ''
             tags:
               - {key: transmission.latency, value: not null}
+              - { key: mq.topic, value: TopicTest }
+              - { key: mq.broker, value: not null }

Review Comment:
   It seems contains a bug when using `not blank `. The validator.out log like below
   ```
     Segment[a7cbd27526b941c1b22a22a6b6f6b85e.38.16670159779570000] e
     expected:	Span[0, 1] RocketMQ/TopicTest/Producer
     actual:	span[0, 1] RocketMQ/TopicTest/Producer
     reason:	[tag(mq.broker) value]: expected=>{not blank}, actual=>{172.23.0.2:10911}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org