You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/11 11:03:28 UTC

[GitHub] [incubator-kyuubi] wForget opened a new pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

wForget opened a new pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213


   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   Please see #1204 for details.
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#discussion_r727654044



##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala
##########
@@ -55,6 +55,20 @@ object HighAvailabilityConf {
       .booleanConf
       .createWithDefault(false)
 
+  val HA_ZK_AUTH_SASL_KERBEROS: ConfigEntry[Boolean] =
+    buildConf("ha.zookeeper.auth.sasl.kerberos")
+      .doc("Set to true if the zookeeper ensemble is kerberized")
+      .version("1.4.0")
+      .booleanConf
+      .createWithDefault(UserGroupInformation.isSecurityEnabled)
+
+  val HA_ZK_AUTH: OptionalConfigEntry[String] =

Review comment:
       using KYUUBI_UPDATE=1 and run tests locally will update the setting's doc




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#discussion_r732537869



##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala
##########
@@ -41,19 +41,45 @@ object HighAvailabilityConf {
     .stringConf
     .createWithDefault("kyuubi")
 
+  @deprecated(s"using ${HA_ZK_AUTH_TYPE.key} and ${HA_ZK_ENGINE_AUTH_TYPE.key} instead", "1.4.0")
   val HA_ZK_ACL_ENABLED: ConfigEntry[Boolean] =
     buildConf("ha.zookeeper.acl.enabled")
       .doc("Set to true if the zookeeper ensemble is kerberized")
       .version("1.0.0")
       .booleanConf
       .createWithDefault(UserGroupInformation.isSecurityEnabled)
 
-  val HA_ZK_ACL_ENGINE_ENABLED: ConfigEntry[Boolean] =
-    buildConf("ha.zookeeper.acl.engine.enabled")
-      .doc("Set to true if the zookeeper ensemble is kerberized at engine side.")
+  val HA_ZK_AUTH_TYPE: ConfigEntry[String] =
+    buildConf("ha.zookeeper.auth.type")
+      .doc("The type of zookeeper authentication, all candidates are " +
+        s"${ZooKeeperAuthTypes.values.mkString("<ul><li>", "</li><li> ", "</li></ul>")}")
       .version("1.4.0")
-      .booleanConf
-      .createWithDefault(false)
+      .stringConf
+      .checkValues(ZooKeeperAuthTypes.values.map(_.toString))
+      .createWithDefault(ZooKeeperAuthTypes.getDefault().toString)

Review comment:
       maybe NONE as default？ 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#issuecomment-947422175


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1213](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13cd7ec) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d0d5fb6d4fd177c5e4325bbb3cf5a602c10a9be3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0d5fb6) will **decrease** coverage by `0.02%`.
   > The diff coverage is `72.97%`.
   
   > :exclamation: Current head 13cd7ec differs from pull request most recent head fa88ffb. Consider uploading reports for the commit fa88ffb to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1213      +/-   ##
   ============================================
   - Coverage     73.10%   73.08%   -0.03%     
     Complexity       41       41              
   ============================================
     Files           175      176       +1     
     Lines          6846     6903      +57     
     Branches        835      845      +10     
   ============================================
   + Hits           5005     5045      +40     
   - Misses         1441     1447       +6     
   - Partials        400      411      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.22% <ø> (-0.02%)` | :arrow_down: |
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `55.81% <0.00%> (ø)` | |
   | [...che/kyuubi/ha/client/ZooKeeperClientProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ab29LZWVwZXJDbGllbnRQcm92aWRlci5zY2FsYQ==) | `70.17% <56.52%> (-11.88%)` | :arrow_down: |
   | [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `86.86% <58.33%> (-2.91%)` | :arrow_down: |
   | [...g/apache/kyuubi/ha/client/ZooKeeperAuthTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ab29LZWVwZXJBdXRoVHlwZXMuc2NhbGE=) | `60.00% <60.00%> (ø)` | |
   | [...apache/kyuubi/ha/client/ZooKeeperACLProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ab29LZWVwZXJBQ0xQcm92aWRlci5zY2FsYQ==) | `85.00% <80.00%> (-0.72%)` | :arrow_down: |
   | [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.85% <100.00%> (+0.32%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d0d5fb6...fa88ffb](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#discussion_r734223235



##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala
##########
@@ -41,11 +41,9 @@ class ZooKeeperACLProvider(conf: KyuubiConf) extends ACLProvider {
       nodeAcls.addAll(ZooDefs.Ids.CREATOR_ALL_ACL)
     }
 
-    if (conf.get(HighAvailabilityConf.HA_ZK_ACL_ENABLED) &&
-      conf.get(HighAvailabilityConf.HA_ZK_ENGINE_REF_ID).isEmpty) {
+    if (conf.get(HighAvailabilityConf.HA_ZK_ENGINE_REF_ID).isEmpty && enabledServerAcls()) {

Review comment:
       Not related to this PR, this now make the zk auth very complicated. We can separate engine and server auth in the future if they have only a little in common




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] wForget commented on pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
wForget commented on pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#issuecomment-947439248


   Hi @yaooqinn , I have completed the code development and fixed the test cases. Can you help me review it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
wForget commented on a change in pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#discussion_r732554103



##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala
##########
@@ -41,19 +41,45 @@ object HighAvailabilityConf {
     .stringConf
     .createWithDefault("kyuubi")
 
+  @deprecated(s"using ${HA_ZK_AUTH_TYPE.key} and ${HA_ZK_ENGINE_AUTH_TYPE.key} instead", "1.4.0")
   val HA_ZK_ACL_ENABLED: ConfigEntry[Boolean] =
     buildConf("ha.zookeeper.acl.enabled")
       .doc("Set to true if the zookeeper ensemble is kerberized")
       .version("1.0.0")
       .booleanConf
       .createWithDefault(UserGroupInformation.isSecurityEnabled)
 
-  val HA_ZK_ACL_ENGINE_ENABLED: ConfigEntry[Boolean] =
-    buildConf("ha.zookeeper.acl.engine.enabled")
-      .doc("Set to true if the zookeeper ensemble is kerberized at engine side.")
+  val HA_ZK_AUTH_TYPE: ConfigEntry[String] =
+    buildConf("ha.zookeeper.auth.type")
+      .doc("The type of zookeeper authentication, all candidates are " +
+        s"${ZooKeeperAuthTypes.values.mkString("<ul><li>", "</li><li> ", "</li></ul>")}")
       .version("1.4.0")
-      .booleanConf
-      .createWithDefault(false)
+      .stringConf
+      .checkValues(ZooKeeperAuthTypes.values.map(_.toString))
+      .createWithDefault(ZooKeeperAuthTypes.getDefault().toString)

Review comment:
       > maybe NONE as default？
   
   Setting the default value to NONE will be inconsistent with the behavior of the previous version. Do we need to change it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
wForget commented on a change in pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#discussion_r732573266



##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala
##########
@@ -41,19 +41,45 @@ object HighAvailabilityConf {
     .stringConf
     .createWithDefault("kyuubi")
 
+  @deprecated(s"using ${HA_ZK_AUTH_TYPE.key} and ${HA_ZK_ENGINE_AUTH_TYPE.key} instead", "1.4.0")
   val HA_ZK_ACL_ENABLED: ConfigEntry[Boolean] =
     buildConf("ha.zookeeper.acl.enabled")
       .doc("Set to true if the zookeeper ensemble is kerberized")
       .version("1.0.0")
       .booleanConf
       .createWithDefault(UserGroupInformation.isSecurityEnabled)
 
-  val HA_ZK_ACL_ENGINE_ENABLED: ConfigEntry[Boolean] =
-    buildConf("ha.zookeeper.acl.engine.enabled")
-      .doc("Set to true if the zookeeper ensemble is kerberized at engine side.")
+  val HA_ZK_AUTH_TYPE: ConfigEntry[String] =
+    buildConf("ha.zookeeper.auth.type")
+      .doc("The type of zookeeper authentication, all candidates are " +
+        s"${ZooKeeperAuthTypes.values.mkString("<ul><li>", "</li><li> ", "</li></ul>")}")
       .version("1.4.0")
-      .booleanConf
-      .createWithDefault(false)
+      .stringConf
+      .checkValues(ZooKeeperAuthTypes.values.map(_.toString))
+      .createWithDefault(ZooKeeperAuthTypes.getDefault().toString)

Review comment:
       OK, thanks. I will modify it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#discussion_r727654044



##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala
##########
@@ -55,6 +55,20 @@ object HighAvailabilityConf {
       .booleanConf
       .createWithDefault(false)
 
+  val HA_ZK_AUTH_SASL_KERBEROS: ConfigEntry[Boolean] =
+    buildConf("ha.zookeeper.auth.sasl.kerberos")
+      .doc("Set to true if the zookeeper ensemble is kerberized")
+      .version("1.4.0")
+      .booleanConf
+      .createWithDefault(UserGroupInformation.isSecurityEnabled)
+
+  val HA_ZK_AUTH: OptionalConfigEntry[String] =

Review comment:
       using KYUUBI_UPDATE=1 and run tests locally will update the setting's doc




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#discussion_r732564763



##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala
##########
@@ -41,19 +41,45 @@ object HighAvailabilityConf {
     .stringConf
     .createWithDefault("kyuubi")
 
+  @deprecated(s"using ${HA_ZK_AUTH_TYPE.key} and ${HA_ZK_ENGINE_AUTH_TYPE.key} instead", "1.4.0")
   val HA_ZK_ACL_ENABLED: ConfigEntry[Boolean] =
     buildConf("ha.zookeeper.acl.enabled")
       .doc("Set to true if the zookeeper ensemble is kerberized")
       .version("1.0.0")
       .booleanConf
       .createWithDefault(UserGroupInformation.isSecurityEnabled)
 
-  val HA_ZK_ACL_ENGINE_ENABLED: ConfigEntry[Boolean] =
-    buildConf("ha.zookeeper.acl.engine.enabled")
-      .doc("Set to true if the zookeeper ensemble is kerberized at engine side.")
+  val HA_ZK_AUTH_TYPE: ConfigEntry[String] =
+    buildConf("ha.zookeeper.auth.type")
+      .doc("The type of zookeeper authentication, all candidates are " +
+        s"${ZooKeeperAuthTypes.values.mkString("<ul><li>", "</li><li> ", "</li></ul>")}")
       .version("1.4.0")
-      .booleanConf
-      .createWithDefault(false)
+      .stringConf
+      .checkValues(ZooKeeperAuthTypes.values.map(_.toString))
+      .createWithDefault(ZooKeeperAuthTypes.getDefault().toString)

Review comment:
       we seem don't have the ability to auth kerberized zk ensembles in previous versions? The authentication seems to be decided by the zk, not our Kyuubi server settings, personally，I think we shall make this behavior explicitly exposed to our users. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#issuecomment-947422175


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1213](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13cd7ec) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d0d5fb6d4fd177c5e4325bbb3cf5a602c10a9be3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0d5fb6) will **decrease** coverage by `0.02%`.
   > The diff coverage is `72.97%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1213      +/-   ##
   ============================================
   - Coverage     73.10%   73.08%   -0.03%     
     Complexity       41       41              
   ============================================
     Files           175      176       +1     
     Lines          6846     6903      +57     
     Branches        835      845      +10     
   ============================================
   + Hits           5005     5045      +40     
   - Misses         1441     1447       +6     
   - Partials        400      411      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.22% <ø> (-0.02%)` | :arrow_down: |
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `55.81% <0.00%> (ø)` | |
   | [...che/kyuubi/ha/client/ZooKeeperClientProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ab29LZWVwZXJDbGllbnRQcm92aWRlci5zY2FsYQ==) | `70.17% <56.52%> (-11.88%)` | :arrow_down: |
   | [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `86.86% <58.33%> (-2.91%)` | :arrow_down: |
   | [...g/apache/kyuubi/ha/client/ZooKeeperAuthTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ab29LZWVwZXJBdXRoVHlwZXMuc2NhbGE=) | `60.00% <60.00%> (ø)` | |
   | [...apache/kyuubi/ha/client/ZooKeeperACLProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9ab29LZWVwZXJBQ0xQcm92aWRlci5zY2FsYQ==) | `85.00% <80.00%> (-0.72%)` | :arrow_down: |
   | [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.85% <100.00%> (+0.32%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d0d5fb6...13cd7ec](https://codecov.io/gh/apache/incubator-kyuubi/pull/1213?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#issuecomment-947520576


   cc @zhouyifan279 can you help review this too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1213: [KYUUBI #1204] Enhance zookeeper authentication and acls

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1213:
URL: https://github.com/apache/incubator-kyuubi/pull/1213#issuecomment-949275104


   thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org