You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Bastian Hofmann (JIRA)" <ji...@apache.org> on 2010/08/09 17:50:17 UTC
[jira] Created: (SHINDIG-1404) Additional double decoding of
Security Token
Additional double decoding of Security Token
--------------------------------------------
Key: SHINDIG-1404
URL: https://issues.apache.org/jira/browse/SHINDIG-1404
Project: Shindig
Issue Type: Bug
Components: PHP
Reporter: Bastian Hofmann
I found another double decoding of the security token in php shindig, which is still there in the current revision (see SHINDIG-966):
--- - 2010-08-09 16:35:38.000000000 +0200
+++ php/src/gadgets/GadgetContext.php 2010-07-30 13:46:20.000000000 +0200
@@ -285,9 +285,6 @@
* @return SecurityToken An object representation of the token data.
*/
public function validateToken($token, $signer) {
- if (count(explode(':', $token)) < 7) {
- $token = urldecode(base64_decode($token));
- }
if (empty($token)) {
throw new Exception("Missing or invalid security token");
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1404) Additional double decoding of
Security Token
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1404.
-----------------------------------
Fix Version/s: 2.0.0-RC1
Resolution: Fixed
patch applied. thanks!
> Additional double decoding of Security Token
> --------------------------------------------
>
> Key: SHINDIG-1404
> URL: https://issues.apache.org/jira/browse/SHINDIG-1404
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Reporter: Bastian Hofmann
> Fix For: 2.0.0-RC1
>
>
> I found another double decoding of the security token in php shindig, which is still there in the current revision (see SHINDIG-966):
> --- - 2010-08-09 16:35:38.000000000 +0200
> +++ php/src/gadgets/GadgetContext.php 2010-07-30 13:46:20.000000000 +0200
> @@ -285,9 +285,6 @@
> * @return SecurityToken An object representation of the token data.
> */
> public function validateToken($token, $signer) {
> - if (count(explode(':', $token)) < 7) {
> - $token = urldecode(base64_decode($token));
> - }
> if (empty($token)) {
> throw new Exception("Missing or invalid security token");
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.