You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2019/11/05 13:44:36 UTC

[GitHub] [incubator-apisix] membphis commented on a change in pull request #809: fix: core.utils.parse_addr didn't parse IPv6 address correctly

membphis commented on a change in pull request #809: fix: core.utils.parse_addr didn't parse IPv6 address correctly
URL: https://github.com/apache/incubator-apisix/pull/809#discussion_r342569160
 
 

 ##########
 File path: lua/apisix/core/utils.lua
 ##########
 @@ -83,12 +83,28 @@ function _M.dns_parse(resolvers, domain)
 end
 
 
+local function rfind_char(s, ch, idx)
 
 Review comment:
   Single character lookup, is it better than 'string.find'?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services