You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/01 09:12:43 UTC
[GitHub] [zookeeper] championquizzer opened a new pull request #1472: Shellcheck
championquizzer opened a new pull request #1472:
URL: https://github.com/apache/zookeeper/pull/1472
1. Added the shebang
2. Added $(...) notation instead of legacy backticked `...`
3. Added double quote to prevent globbing and word splitting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] anmolnar commented on pull request #1472: ZOOKEEPER-3955 added a shebang or a 'shell' directive to lastRevision.sh
Posted by GitBox <gi...@apache.org>.
anmolnar commented on pull request #1472:
URL: https://github.com/apache/zookeeper/pull/1472#issuecomment-707049160
Merged to master and branch-3.6 branches. Thanks @championquizzer !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1472: ZOOKEEPER-3955 added a shebang or a 'shell' directive to lastRevision.sh
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1472:
URL: https://github.com/apache/zookeeper/pull/1472
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] TomMD commented on pull request #1472: Shellcheck
Posted by GitBox <gi...@apache.org>.
TomMD commented on pull request #1472:
URL: https://github.com/apache/zookeeper/pull/1472#issuecomment-703817694
The Zookeeper project has a process for organizing contributions (see https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute). Could you open a JIRA ticket and update this PR? They'd like to accept these fixes but the process is really helpful to discussion and workflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] championquizzer commented on pull request #1472: Shellcheck
Posted by GitBox <gi...@apache.org>.
championquizzer commented on pull request #1472:
URL: https://github.com/apache/zookeeper/pull/1472#issuecomment-704125663
I opened a JIRA ticket (https://issues.apache.org/jira/browse/ZOOKEEPER-3955). Feel free to let me know if there are any issues. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org