[jira] [Commented] (FLINK-6504) Lack of synchronization on materializedSstFiles in RocksDBKEyedStateBackend

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003925#comment-16003925 ] 

ASF GitHub Bot commented on FLINK-6504:
---------------------------------------

GitHub user shixiaogang opened a pull request:

    https://github.com/apache/flink/pull/3859

    [FLINK-6504] [FLINK-6467] [checkpoints] Add needed synchronization for RocksDBIncrementalSnapshotOperation

    This pull request adds missing synchronization for the access to the following  variables:
    1. `materializedSstFiles` in `RocksDBKeyedStateBackend`: The variable may be accessed simultaneously by the processing thread (read) and the materialization threads (write). Now we use `asynchronousSnapshotLock` to prevent concurrent access.
    2. `newSstFiles`, `oldSstFiles` and `metaStateHandle` in `RocksDBIncrementalSnapshotOperation`: These variables may be accessed by both the cancel thread and the materialization thread. Though the materialization thread are supposed to be stopped when `releaseResources()` is executed, we add synchronization here to prevent potential conflicts.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shixiaogang/flink flink-6504

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3859
    
----
commit 1c1a08e0f7db5ec8663a46c495468583983c7291
Author: xiaogang.sxg <xi...@alibaba-inc.com>
Date:   2017-05-10T01:55:34Z

    Add needed synchronization for RocksDBIncrementalSnapshotOperation

----


> Lack of synchronization on materializedSstFiles in RocksDBKEyedStateBackend
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-6504
>                 URL: https://issues.apache.org/jira/browse/FLINK-6504
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.3.0
>            Reporter: Stefan Richter
>            Assignee: Xiaogang Shi
>
> Concurrent checkpoints could access `materializedSstFiles` in the `RocksDBStateBackend` concurrently. This should be avoided.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)