You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2020/08/17 06:37:49 UTC
[GitHub] [openmeetings] sebawagner opened a new pull request #105: Update Javascript and Build Instructions.
sebawagner opened a new pull request #105:
URL: https://github.com/apache/openmeetings/pull/105
Needs to copy resulting files also to https://github.com/apache/openmeetings-site once this PR is done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #105: Update Javascript and Build Instructions.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #105:
URL: https://github.com/apache/openmeetings/pull/105#discussion_r471264608
##########
File path: openmeetings-server/src/site/xdoc/BuildInstructions.xml
##########
@@ -60,7 +60,7 @@
<section name="Check dependencies">
<source>mvn org.apache.maven.plugins:maven-dependency-plugin:analyze-only</source>
</section>
- <section name="Tips and Gotchas">
+ <section name="Incremental Build and Run Embedded Jetty">
Review comment:
well I rename it back then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner merged pull request #105: Update Javascript and Build Instructions.
Posted by GitBox <gi...@apache.org>.
sebawagner merged pull request #105:
URL: https://github.com/apache/openmeetings/pull/105
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a change in pull request #105: Update Javascript and Build Instructions.
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #105:
URL: https://github.com/apache/openmeetings/pull/105#discussion_r471260403
##########
File path: openmeetings-server/src/site/xdoc/BuildInstructions.xml
##########
@@ -60,7 +60,7 @@
<section name="Check dependencies">
<source>mvn org.apache.maven.plugins:maven-dependency-plugin:analyze-only</source>
</section>
- <section name="Tips and Gotchas">
+ <section name="Incremental Build and Run Embedded Jetty">
Review comment:
I only have concern regarding this section renaming: only 1 item is about Jetty ...
See no reason to change the section name :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #105: Update Javascript and Build Instructions.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #105:
URL: https://github.com/apache/openmeetings/pull/105#discussion_r471264161
##########
File path: openmeetings-server/src/site/xdoc/BuildInstructions.xml
##########
@@ -60,7 +60,7 @@
<section name="Check dependencies">
<source>mvn org.apache.maven.plugins:maven-dependency-plugin:analyze-only</source>
</section>
- <section name="Tips and Gotchas">
+ <section name="Incremental Build and Run Embedded Jetty">
Review comment:
yeah the other commands are all about incremental building modules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a change in pull request #105: Update Javascript and Build Instructions.
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #105:
URL: https://github.com/apache/openmeetings/pull/105#discussion_r471263858
##########
File path: openmeetings-server/src/site/xdoc/BuildInstructions.xml
##########
@@ -60,7 +60,7 @@
<section name="Check dependencies">
<source>mvn org.apache.maven.plugins:maven-dependency-plugin:analyze-only</source>
</section>
- <section name="Tips and Gotchas">
+ <section name="Incremental Build and Run Embedded Jetty">
Review comment:
this section contains 5-6 run commands
and only one of them is about Jetty
others are about Tomcat ....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #105: Update Javascript and Build Instructions.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #105:
URL: https://github.com/apache/openmeetings/pull/105#discussion_r471263090
##########
File path: openmeetings-server/src/site/xdoc/BuildInstructions.xml
##########
@@ -60,7 +60,7 @@
<section name="Check dependencies">
<source>mvn org.apache.maven.plugins:maven-dependency-plugin:analyze-only</source>
</section>
- <section name="Tips and Gotchas">
+ <section name="Incremental Build and Run Embedded Jetty">
Review comment:
It actually mentions in this section:
mvn clean -P allModules,quick,mysql jetty:run-exploded
Which will run the Embedded Jetty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org