You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by klueska <gi...@git.apache.org> on 2016/09/08 08:31:14 UTC

[GitHub] spark pull request #14644: [MESOS] Enable GPU support with Mesos

Github user klueska commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14644#discussion_r77965263
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala ---
    @@ -103,6 +103,7 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
       private val stateLock = new ReentrantLock
     
       val extraCoresPerExecutor = conf.getInt("spark.mesos.extra.cores", 0)
    +  val maxGpus = conf.getInt("spark.mesos.gpus.max", 0)
    --- End diff --
    
    I know in a previous iteration of this patch we were using the config variable `spark.mesos.gpu.enabled=true` instead of `spark.mesos.gpu.max=XX`. Why did this change? If I nee to set a max, how do I know how big to make the value? Do the spark configuration scripts allow me to run bash commands to programattically count the total number of GPUs on the machine if that's my desired max?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org