You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Michael Prieß (JIRA)" <ji...@apache.org> on 2012/07/21 22:31:33 UTC

[jira] [Created] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Michael Prieß created KARAF-1657:
------------------------------------

             Summary: org.ops4j.pax.url.mvn.proxySupport=false
                 Key: KARAF-1657
                 URL: https://issues.apache.org/jira/browse/KARAF-1657
             Project: Karaf
          Issue Type: Improvement
            Reporter: Michael Prieß


The configuration of org.ops4j.pax.url.mvn.proxySupport is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. I prefer the solution to set the configuration per default to false inside org.ops4j.pax.url.mvn.cfg 

#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Posted by "Michael Prieß (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Prieß updated KARAF-1657:
---------------------------------

    Description: 
{code}
#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true
{code}

http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol 

The configuration of pax url is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 

I prefer to set the configuration per default to false.

  was:
{code}
#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true
{code}

The configuration of org.ops4j.pax.url.mvn.proxySupport is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 

I prefer to set the configuration per default to false.

    
> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}
> http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol 
> The configuration of pax url is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Posted by "Michael Prieß (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Prieß updated KARAF-1657:
---------------------------------

    Description: 
The configuration of org.ops4j.pax.url.mvn.proxySupport is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. I prefer the solution to set the configuration per default to false inside org.ops4j.pax.url.mvn.cfg 

{code}
#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true
{code}

  was:
The configuration of org.ops4j.pax.url.mvn.proxySupport is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. I prefer the solution to set the configuration per default to false inside org.ops4j.pax.url.mvn.cfg 

#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true

    
> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>
> The configuration of org.ops4j.pax.url.mvn.proxySupport is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. I prefer the solution to set the configuration per default to false inside org.ops4j.pax.url.mvn.cfg 
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420417#comment-13420417 ] 

Andreas Pieber commented on KARAF-1657:
---------------------------------------

I'm also +1 for changing this to false; nevertheless, last time I chatted with JB about this the state was: we'll change this ASAP all side conditions are clear. Is there any update on this before we finally change this property?
                
> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>            Assignee: Freeman Fang
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}
> http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol 
> The configuration of pax url is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Assigned] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang reassigned KARAF-1657:
-----------------------------------

    Assignee: Freeman Fang
    
> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>            Assignee: Freeman Fang
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}
> http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol 
> The configuration of pax url is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Posted by "Michael Prieß (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Prieß updated KARAF-1657:
---------------------------------

    Description: 
{code}
#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true
{code}

The configuration of org.ops4j.pax.url.mvn.proxySupport is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 

I prefer to set the configuration per default to false.

  was:
The configuration of org.ops4j.pax.url.mvn.proxySupport is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. I prefer the solution to set the configuration per default to false inside org.ops4j.pax.url.mvn.cfg 

{code}
#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true
{code}

    
> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}
> The configuration of org.ops4j.pax.url.mvn.proxySupport is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Resolved] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang resolved KARAF-1657.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.0
                   2.3.0
                   2.2.9

commit fix
http://svn.apache.org/viewvc?rev=1364858&view=rev for trunk
http://svn.apache.org/viewvc?rev=1364857&view=rev for 2.3.x branch
http://svn.apache.org/viewvc?rev=1364856&view=rev for 2.2.x branch
                
> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>            Assignee: Freeman Fang
>             Fix For: 2.2.9, 2.3.0, 3.0.0
>
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}
> http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol 
> The configuration of pax url is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Comment Edited] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420484#comment-13420484 ] 

Freeman Fang edited comment on KARAF-1657 at 7/23/12 7:29 AM:
--------------------------------------------------------------

Hi Andreas,

We currently comment out org.ops4j.pax.url.mvn.proxySupport configuration by default, which means in Karaf we  use default value  of org.ops4j.pax.url.mvn.proxySupport from PAX-URL out-of-box so far, which is "true"(according to PAX-URL docs). By my test, the default org.ops4j.pax.url.mvn.proxySupport=true in  PAX-URL  means, it will just try to use(but not only use proxy) maven proxy support if the proxy configuration is in maven settings.xml and the proxy is available. That said,  PAX-URL  can still use normal maven way even the proxy isn't available or there's no proxy configuration in maven settings.xml with default org.ops4j.pax.url.mvn.proxySupport=true. 

So the current configuration (including the comments)
{code}
#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true
{code}

isn't correct, as it's actually same behavior with or without
org.ops4j.pax.url.mvn.proxySupport=true

So I think we need change it to
{code}
#
# Uncomment if you don't wanna use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=false
{code}
And I don't see the side effect of this change, as all what we change is still in the comment.

I might miss something, so if other guys have different input, please let me know.

Regards
Freeman
                
      was (Author: ffang):
    Hi Andreas,

We currently comment out org.ops4j.pax.url.mvn.proxySupport configuration by default, which means in Karaf we  use default value  of org.ops4j.pax.url.mvn.proxySupport from PAX-URL out-of-box so far, which is "true"(according to PAX-URL docs). By my test, the default org.ops4j.pax.url.mvn.proxySupport=true in  PAX-URL  means, it will just try to use(but not only use proxy) maven proxy support if the proxy configuration is in maven settings.xml and the proxy is available. That said,  PAX-URL  can still use normal maven way even the proxy isn't available or there's no proxy configuration in maven settings.xml with default org.ops4j.pax.url.mvn.proxySupport=true. 

So the current configuration (including the comments)
#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true

isn't correct, as it's actually same behavior with or without
org.ops4j.pax.url.mvn.proxySupport=true

So I think we need change it to
#
# Uncomment if you don't wanna use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=false

And I don't see the side effect of this change, as all what we change is still in the comment.

I might miss something, so if other guys have different input, please let me know.

Regards
Freeman
                  
> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>            Assignee: Freeman Fang
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}
> http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol 
> The configuration of pax url is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Work started] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on KARAF-1657 started by Freeman Fang.

> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>            Assignee: Freeman Fang
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}
> http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol 
> The configuration of pax url is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421343#comment-13421343 ] 

Andreas Pieber commented on KARAF-1657:
---------------------------------------

oh... dargl... this was the wrong org.ops4j.pax.url.mvn property I thought about. This happens if you read a post with only half your mind on -.-. 

Terrible sorry for the confusion and thanks for commiting/fixing this.

Kind regards,
Andreas
                
> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>            Assignee: Freeman Fang
>             Fix For: 2.2.9, 2.3.0, 3.0.0
>
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}
> http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol 
> The configuration of pax url is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (KARAF-1657) org.ops4j.pax.url.mvn.proxySupport=false

Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420484#comment-13420484 ] 

Freeman Fang commented on KARAF-1657:
-------------------------------------

Hi Andreas,

We currently comment out org.ops4j.pax.url.mvn.proxySupport configuration by default, which means in Karaf we  use default value  of org.ops4j.pax.url.mvn.proxySupport from PAX-URL out-of-box so far, which is "true"(according to PAX-URL docs). By my test, the default org.ops4j.pax.url.mvn.proxySupport=true in  PAX-URL  means, it will just try to use(but not only use proxy) maven proxy support if the proxy configuration is in maven settings.xml and the proxy is available. That said,  PAX-URL  can still use normal maven way even the proxy isn't available or there's no proxy configuration in maven settings.xml with default org.ops4j.pax.url.mvn.proxySupport=true. 

So the current configuration (including the comments)
#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true

isn't correct, as it's actually same behavior with or without
org.ops4j.pax.url.mvn.proxySupport=true

So I think we need change it to
#
# Uncomment if you don't wanna use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=false

And I don't see the side effect of this change, as all what we change is still in the comment.

I might miss something, so if other guys have different input, please let me know.

Regards
Freeman
                
> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>            Assignee: Freeman Fang
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}
> http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol 
> The configuration of pax url is per default true. If you read this comment inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration must be false. 
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira