[GitHub] [celix] rlenferink commented on a diff in pull request #446: Feature/separate deprecated headers

[GitBox <gi...@apache.org>]

rlenferink commented on code in PR #446:
URL: https://github.com/apache/celix/pull/446#discussion_r977988735


##########
cmake/celix_project/CelixProject.cmake:
##########
@@ -83,5 +83,31 @@ MACRO(celix_subproject)
     ENDIF (${NAME})
 ENDMACRO(celix_subproject)
 
+#[[
+Custom target which list the Celix CMake targets that are still using deprecated headers.
+]]
+if (NOT TARGET celix-deprecated)
+    add_custom_target(celix-deprecated
+        COMMAND ${CMAKE_COMMAND} -E echo "Targets still using deprecated utils headers: $<JOIN:$<TARGET_PROPERTY:celix-deprecated,UTIL_TARGETS>, >"
+    )
+    set_target_properties(celix-deprecated PROPERTIES "UTIL_TARGETS" "")
+endif ()
+
+
+#[[
+Add include path for the Celix utils deprecated headers to the provided target (as PRIVATE)
+
+```CMake
+celix_v2_utils_headers(<target_name>))

Review Comment:
   Forgot to update ?
   ```suggestion
   celix_deprecated_utils_headers(<target_name>))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org