You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2022/01/06 19:51:11 UTC
[kudu-CR] [test] Add option to run tests with encrypted env
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18130
Change subject: [test] Add option to run tests with encrypted env
......................................................................
[test] Add option to run tests with encrypted env
Sometimes it's useful to run tests with data at rest encryption enabled.
To make this possible, this patch introduces a new environment variable:
KUDU_ENCRYPT_DATA_IN_TESTS.
Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
---
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
2 files changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/18130/1
--
To view, visit http://gerrit.cloudera.org:8080/18130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
Gerrit-Change-Number: 18130
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR] [test] Add option to run tests with encrypted env
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18130 )
Change subject: [test] Add option to run tests with encrypted env
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/18130/1/src/kudu/util/test_util.h
File src/kudu/util/test_util.h:
http://gerrit.cloudera.org:8080/#/c/18130/1/src/kudu/util/test_util.h@89
PS1, Line 89:
: static KuduTestEventListener* listener_;
> Why this change?
I missed this, thanks. It was actually for c423172, but I didn't end up using it.
--
To view, visit http://gerrit.cloudera.org:8080/18130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
Gerrit-Change-Number: 18130
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Jan 2022 10:08:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Add option to run tests with encrypted env
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18130
to look at the new patch set (#2).
Change subject: [test] Add option to run tests with encrypted env
......................................................................
[test] Add option to run tests with encrypted env
Sometimes it's useful to run tests with data at rest encryption enabled.
To make this possible, this patch introduces a new environment variable:
KUDU_ENCRYPT_DATA_IN_TESTS.
Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
---
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/18130/2
--
To view, visit http://gerrit.cloudera.org:8080/18130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
Gerrit-Change-Number: 18130
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] Add option to run tests with encrypted env
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18130 )
Change subject: [test] Add option to run tests with encrypted env
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
Gerrit-Change-Number: 18130
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Jan 2022 19:56:53 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Add option to run tests with encrypted env
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18130 )
Change subject: [test] Add option to run tests with encrypted env
......................................................................
[test] Add option to run tests with encrypted env
Sometimes it's useful to run tests with data at rest encryption enabled.
To make this possible, this patch introduces a new environment variable:
KUDU_ENCRYPT_DATA_IN_TESTS.
Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
Reviewed-on: http://gerrit.cloudera.org:8080/18130
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
2 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
Gerrit-Change-Number: 18130
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] Add option to run tests with encrypted env
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18130 )
Change subject: [test] Add option to run tests with encrypted env
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
Gerrit-Change-Number: 18130
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Jan 2022 06:21:32 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Add option to run tests with encrypted env
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: [test] Add option to run tests with encrypted env
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
Gerrit-Change-Number: 18130
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] Add option to run tests with encrypted env
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18130 )
Change subject: [test] Add option to run tests with encrypted env
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18130/1/src/kudu/util/test_util.h
File src/kudu/util/test_util.h:
http://gerrit.cloudera.org:8080/#/c/18130/1/src/kudu/util/test_util.h@89
PS1, Line 89:
: static KuduTestEventListener* listener_;
Why this change?
--
To view, visit http://gerrit.cloudera.org:8080/18130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7cb84c3853126f561e31a2d843fa46a3a71d85a
Gerrit-Change-Number: 18130
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Jan 2022 00:48:29 +0000
Gerrit-HasComments: Yes