[GitHub] [druid] jihoonson commented on pull request #10683: Upgrade Guava to 27

[GitBox <gi...@apache.org>]

jihoonson commented on pull request #10683:
URL: https://github.com/apache/druid/pull/10683#issuecomment-754230969


   > Not sure how to proceed here. Things are failing because... SPOTBUGS for an issue I didn't add, not enough test coverage but I didn't add any new functionality, license failures, again, not sure how these changes did that.
   
   Hi @belugabehr, we can ignore them if they are truly irrelevant, I haven't looked into details of Spotbugs or Intellij inspection failures though. However, I do see many real test failures in unit tests and integration tests which should be fixed before this PR gets merged. Also, the guava version is important to be compatible to other ecosystems and libraries such as Hadoop or AWS SDK. Integration tests for them are not running on Travis as they require additional setup such as AWS credentials, so you and the reviewers of this PR should run them manually before merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org